Bug 705374 – net-proxy/squidguard-1.6.0 : QA Notice: 'automake' called by src_prepare: net-proxy/squidguard-1.6.0

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Toralf Förster 2020-01-13 20:01:15 UTC]

QA: prepare
QA Notice: 'automake' called by src_prepare: net-proxy/squidguard-1.6.0
Use autotools.eclass instead of calling 'automake' directly.

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_developer-20200109-231533

  -------------------------------------------------------------------

[Comment 1 Toralf Förster 2020-01-13 20:01:17 UTC]

Created attachment 603216 [details]
etc.portage.tbz2

[Comment 2 Toralf Förster 2020-01-13 20:01:20 UTC]

Created attachment 603218 [details]
net-proxy:squidguard-1.6.0:20200113-194152.log

[Comment 3 Sergey Popov (RETIRED) 2020-01-14 07:52:30 UTC]

Yep, i am aware of this. Unfortunately i do not know how to avoid this, because eautomake does nothing(on purpose, and i assume that this is correct behaviour, as Makefile.am does not exist in source code of squidguard) ,thus i forced to use this ugly hack.

@qa: please advise

[Comment 4 Michał Górny 2020-01-14 09:01:39 UTC]

Copy or symlink the needed files? Or maybe you could just set some make vars to e.g. use system 'install'.

[Comment 5 Sergey Popov (RETIRED) 2020-01-14 10:21:28 UTC]

(In reply to Michał Górny from comment #4)
> Copy or symlink the needed files? Or maybe you could just set some make vars
> to e.g. use system 'install'.

I do not really understand autotools internals that much and copying only install-sh did not work :-(

[Comment 6 Michał Górny 2020-01-21 15:58:11 UTC]

Created attachment 603860 [details, diff]
0001-net-proxy-squidguard-Replace-automake-call.patch

I've just tried as done in the attached patch, and it seems to work for me.

[Comment 7 Larry the Git Cow 2020-01-22 11:57:36 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=badc3b9ce78ad3d67d43d217c1a328d71af82f26

commit badc3b9ce78ad3d67d43d217c1a328d71af82f26
Author:     Sergey Popov <[e-mail]>
AuthorDate: 2020-01-22 11:39:16 +0000
Commit:     Sergey Popov <[e-mail]>
CommitDate: 2020-01-22 11:56:51 +0000

    net-proxy/squidguard: fix QA issue with automake call in src_prepare
    
    Closes: https://bugs.gentoo.org/705374
    Reported-by: Toralf Förster <[e-mail]>
    Signed-off-by: Michał Górny <[e-mail]>
    Signed-off-by: Sergey Popov <[e-mail]>
    Package-Manager: Portage-2.3.84, Repoman-2.3.11

 net-proxy/squidguard/squidguard-1.6.0.ebuild | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)