Bug 705254

Summary:	=games-action/openclonk-7.0 uses lexicographical version compare
Product:	Gentoo Linux	Reporter:	Sergei Trofimovich (RETIRED) <slyfox>
Component:	Current packages	Assignee:	Gentoo Games <games>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	705240

Description Sergei Trofimovich (RETIRED) gentoo-dev

2020-01-12 11:19:08 UTC

games-action/openclonk uses lexicographical string version compare:

games-action/openclonk/openclonk-7.0.ebuild:	if [[ $(tc-getCXX) == *g++* && $(gcc-version) < 4.9 ]] ; then

The intention is likely to use 'ver_cmp'. See bug #705240 for hints to fix it.

Comment 1 Larry the Git Cow gentoo-dev

2020-02-18 14:40:34 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5826fd14fa4f2cfb27fab52fa6fbf8a8483badd4

commit 5826fd14fa4f2cfb27fab52fa6fbf8a8483badd4
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-02-18 14:40:11 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-02-18 14:40:15 +0000

    games-action/openclonk: drop outdated compiler check, bug #705254
    
    Avoid lexicographical compare in pkg_setup().
    
    Closes: https://bugs.gentoo.org/705254
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 games-action/openclonk/openclonk-7.0.ebuild | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)