| Summary: | new ebuild for tth | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Niels Laukens <nielchiano> |
| Component: | New packages | Assignee: | Text-Markup Team (OBSOLETE) <text-markup+disabled> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | davide.angelocola |
| Priority: | High | Keywords: | EBUILD |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
tth-3.64.ebuild
new version and changed beginner-mistakes |
||
|
Description
Niels Laukens
2004-11-08 02:48:10 UTC
Created attachment 43523 [details]
tth-3.64.ebuild
There is NO version checking!!!
I tested it for 3.64
Hi, thanks for using and playing with Gentoo :) Feel free and relax to write your first ebuild. It looks nice and tidy though you created it for the first time. However, there are several mistakes you need to change. First, it doesn't contain ebuild header (see the top of /usr/portage/skel.ebuild). It is required for every ebuild to go into our CVS. Second, DEPEND="virtual/glibc" should be DEPEND="virtual/libc" (we changed the name convention). Also, if DEPEND == RDEPEND, you shouldn't write RDEPEND. See "DEPEND and RDEPEND" in Gentoo Developers Handbook (http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=3&chap=1). Lastly, LICENSE could be "free-noncomm" as license.txt says: "You may freely use this software for non-commercial purposes." (then you need to add "dodoc license.txt" in turn) There are several other things I'd like to add, but that'd be too much for the first ebuild lesson ;) Please rewrite your ebuild following the instruction above, and attach it here when you're done. Thanks in advance. ok, just to let you know that I will (try to) update this, but am currently "out of spare time" Created attachment 51046 [details]
new version and changed beginner-mistakes
Ok, low-spare-time-condition solved (exams are over)...
They updated the version, so I changed the ebuild to reflect that.
I also corrected the mentioned beginner-mistakes. anything more I need to
change?
LICENCE should be LICENSE, but that's not big deal. (I corrected it anyway) It compiles and runs flawlessly ;) I made several changes to your ebuild and commit it. If you have any question about the changes I made, feel free to ask. (please post comments to this bug) Thanks for your contribution. Does that mean that the file will be availible on the gentoo-file-servers? or will it be downloaded from the author's site? because you can only download the latest version from the author, so if a new version get's released it will break the digest, etc. utilities: ps2gif ps2png latex2gif should be installed as well... add dobin tth ps2gif ps2png latex2gif as well ? ttd works on AMD64, please consider augmenting its KEYWORDS with ~amd64. (In reply to comment #8) > ttd works on AMD64, please consider augmenting its KEYWORDS with ~amd64. I confirm |