Summary: | games-engines/scummvm-2.1.0 USE=fluidsynth with media-sound/fluidsynth-2.1.0 - In file included from ./common/scummsys.h:472, from audio/softsynth/fluidsynth.cpp:23: ./common/forbidden.h:57:89: error: expected ‘)’ before ‘SYMBOL’ | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alexandra Parker <alex.iris.parker> |
Component: | Current packages | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | PATCH |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Changes poisoning strategy for printf |
Description
Alexandra Parker
2019-12-30 05:09:05 UTC
Created attachment 601754 [details, diff]
Changes poisoning strategy for printf
(In reply to Alex Parker from comment #0) > But the following in fluidsynth/log.h triggers this macro expansion, causing > a compiler error: Can you provide that coompiler error message for clarity's sake? Attaching the full build log would help as well. In file included from ./common/scummsys.h:472, from audio/softsynth/fluidsynth.cpp:23: ./common/forbidden.h:57:89: error: expected ‘)’ before ‘SYMBOL’ 57 | #define FORBIDDEN_SYMBOL_REPLACEMENT FORBIDDEN_look_at_common_forbidden_h_for_more_info SYMBOL !%* | ^~~~~~ In file included from /usr/include/fluidsynth.h:105, from audio/softsynth/fluidsynth.cpp:38: /usr/include/fluidsynth/log.h:82:24: note: to match this ‘(’ 82 | __attribute__ ((format (printf, 2, 3))) | ^ make: *** [Makefile.common:121: audio/softsynth/fluidsynth.o] Error 1 make: *** Waiting for unfinished jobs.... (In reply to Jeroen Roovers from comment #3) > In file included from ./common/scummsys.h:472, > from audio/softsynth/fluidsynth.cpp:23: > ./common/forbidden.h:57:89: error: expected ‘)’ before ‘SYMBOL’ > 57 | #define FORBIDDEN_SYMBOL_REPLACEMENT > FORBIDDEN_look_at_common_forbidden_h_for_more_info SYMBOL !%* > | > ^~~~~~ > In file included from /usr/include/fluidsynth.h:105, > from audio/softsynth/fluidsynth.cpp:38: > /usr/include/fluidsynth/log.h:82:24: note: to match this ‘(’ > 82 | __attribute__ ((format (printf, 2, 3))) > | ^ > make: *** [Makefile.common:121: audio/softsynth/fluidsynth.o] Error 1 > make: *** Waiting for unfinished jobs.... Yes that's exactly the error message. Sorry! Although I like your fix better, they've already fixed it in https://github.com/scummvm/scummvm/commit/8593a9e1e4e8dd1f5dfac9b1304a417df9a742e6. Hah spoke too soon and didn't read the rest of the bug report. They did this instead! https://github.com/scummvm/scummvm/commit/68758a879e0c8ecc0d40962516d4e808aa4e15e5 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d4b50daa7a356bbf112e37bd712d3d7b29d1c001 commit d4b50daa7a356bbf112e37bd712d3d7b29d1c001 Author: James Le Cuirot <chewi@gentoo.org> AuthorDate: 2019-12-30 22:37:09 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2019-12-30 22:38:24 +0000 games-engines/scummvm: Upstream patch for fluidsynth-2.1.0 Closes: https://bugs.gentoo.org/704230 Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: James Le Cuirot <chewi@gentoo.org> .../scummvm/files/scummvm-2.1.0-fluidsynth.patch | 39 ++++++++++++++++++++++ games-engines/scummvm/scummvm-2.1.0.ebuild | 1 + 2 files changed, 40 insertions(+) |