Summary: | [Future EAPI] die instead of outputting QA warning when encountering unknown commands during phase processing | ||
---|---|---|---|
Product: | Gentoo Hosted Projects | Reporter: | Tim Harder <radhermit> |
Component: | PMS/EAPI | Assignee: | PMS/EAPI <pms> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | dev-portage, esigra, ferringb, mgorny, sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=662992 https://bugs.gentoo.org/show_bug.cgi?id=566738 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 174380 |
Description
Tim Harder
2019-12-18 05:37:17 UTC
For more inspiration, here is how pkgcore handles things: https://github.com/pkgcore/pkgcore/blob/master/ebd/ebuild.bash#L332 Let's make it fatal for EAPI 8. (In reply to Zac Medico from comment #2) > Let's make it fatal for EAPI 8. Is this in EAPI 8? Note that this is more of a pain for src_test where often there are false positives. No, it has not been proposed for EAPI 8. However, I think it is still fine to add it at this point. Not that anyone has time to push more of EAPI 8 forward. I presume this is just about commands directly called by ebuild and not by external tools/scripts. Would this only catch commands called directly from a phase function, or also commands executed from within the package's build system? For the latter, I've seen several false positives, so I'm sceptical if catching this would be feasible. (In reply to Ulrich Müller from comment #5) > Would this only catch commands called directly from a phase function Yes. command_not_found_handle() function here is not exported. > or also commands executed from within the package's build system? No. Such behavior would require additional 'export -f command_not_found_handle'. |