Bug 703212

Summary:	net-misc/socat-1.7.3.2 with sys-libs/musl - xio-ip4.c:49:14: error: 'NETDB_INTERNAL' undeclared (first use in this function); did you mean 'OPT_INTERVALL'?
Product:	Gentoo Linux	Reporter:	Michael 'veremitz' Everitt <gentoo>
Component:	Current packages	Assignee:	Sam James <sam>
Status:	RESOLVED FIXED
Severity:	normal	CC:	musl, netmon
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://git.alpinelinux.org/aports/tree/main/socat
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	726646
Bug Blocks:	430702
Attachments:	successful build no patches build.log emerge --info socat-1.7.3.4 build.log [working] socat-1.7.3.3 build.log [working] Upstream drop gethostbyname

Description Michael 'veremitz' Everitt 2019-12-17 12:44:11 UTC

socat requires three patches to build under musl-libc.

See: https://git.alpinelinux.org/aports/tree/main/socat

Comment 1 Jeroen Roovers (RETIRED) gentoo-dev

2019-12-18 05:57:54 UTC

Fails how?

Comment 2 Jory A. Pratt gentoo-dev

2019-12-18 10:16:20 UTC

Created attachment 600012 [details]
successful build no patches

Without a proper build.log and emerge --info we have no way to duplicate the issue. As you can see the build is successful based off of ~testing.

Comment 3 Michael 'veremitz' Everitt 2019-12-18 18:05:53 UTC

Created attachment 600060 [details]
build.log

My bad ...

Comment 4 Michael 'veremitz' Everitt 2019-12-18 18:07:10 UTC

Created attachment 600062 [details]
emerge --info

My bad:

It appears only the internal-netdb patch is actually required: https://git.alpinelinux.org/aports/tree/main/socat/netdb-internal.patch

This has been fixed upstream, but I cannot trace which commit to compat.h it actually happened.

Comment 5 Jory A. Pratt gentoo-dev

2019-12-18 18:33:31 UTC

(In reply to Michael 'veremitz' Everitt from comment #4)
> Created attachment 600062 [details]
> emerge --info
> 
> My bad:
> 
> It appears only the internal-netdb patch is actually required:
> https://git.alpinelinux.org/aports/tree/main/socat/netdb-internal.patch
> 
> This has been fixed upstream, but I cannot trace which commit to compat.h it
> actually happened.

I just checked compat.h from .2 to .3 and no changes are indicated. I would suggest bring .3 stable it has been around for over 9 months now.

Comment 6 Michael 'veremitz' Everitt 2020-01-27 14:56:30 UTC

Created attachment 605174 [details]
socat-1.7.3.4 build.log [working]

1.7.3.4 works fine.

Comment 7 Michael 'veremitz' Everitt 2020-01-27 14:58:15 UTC

Created attachment 605176 [details]
socat-1.7.3.3 build.log [working]

1.7.3.3 working.

Comment 8 Jory A. Pratt gentoo-dev

2020-01-27 16:53:27 UTC

This is not resolved while it is still broken for stable users. Please either open a stable bug for 1.7.3.3 or apply the patch I will attach to the bug for 1.7.3.2

Comment 9 Jory A. Pratt gentoo-dev

2020-01-27 16:54:22 UTC

Created attachment 605178 [details, diff]
Upstream drop gethostbyname

Patch as applied on upstream 1.7.3.3 branch

Comment 10 Jeroen Roovers (RETIRED) gentoo-dev

2020-06-01 11:10:37 UTC Comment hidden (obsolete)

(In reply to Jory A. Pratt from comment #8)
> Please either open a stable bug for 1.7.3.3

Yes, why don't you.

Comment 11 Michael 'veremitz' Everitt 2020-06-01 12:59:18 UTC Comment hidden (obsolete)

(In reply to Jeroen Roovers from comment #10)
> (In reply to Jory A. Pratt from comment #8)
> > Please either open a stable bug for 1.7.3.3
> 
> Yes, why don't you.

Come on children .. :P

Comment 12 Michael 'veremitz' Everitt 2020-06-01 13:32:28 UTC Comment hidden (obsolete)

One more time before I report to ComRel and QA. This bug is NOT fixed until the patch is incorporated or the stable request complete.

Stop pissing about jer.