Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 702702

Summary: app-emulation/qemu-4.2.0 patches
Product: Gentoo Linux Reporter: Joakim Tjernlund <joakim.tjernlund>
Component: Current packagesAssignee: Matthias Maier <tamiko>
Status: RESOLVED OBSOLETE    
Severity: normal CC: graysonchsi, jstein, slyfox, virtualization
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Remove ugly debug in console
Make O flag require P

Description Joakim Tjernlund 2019-12-13 16:06:38 UTC
Here are two paches I have been carrying in our qemu for a long time.
Please consider adding them for qemu-4.2.0
Comment 1 Joakim Tjernlund 2019-12-13 16:08:04 UTC
Created attachment 599348 [details, diff]
Remove ugly debug in console
Comment 2 Joakim Tjernlund 2019-12-13 16:09:14 UTC
Created attachment 599350 [details, diff]
Make O flag require P
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2019-12-13 20:12:16 UTC
Can you send those upstream as well?
Comment 4 Joakim Tjernlund 2019-12-14 11:31:36 UTC
(In reply to Sergei Trofimovich from comment #3)
> Can you send those upstream as well?

I can but it will take time, if upstream will take them, until they
are in a release though.
My question is, will you take them even if upstream don't?

Another thing, have you considered making F flag default?
That flag make QEMU user so much easier to use.
Comment 5 Joakim Tjernlund 2019-12-16 09:17:28 UTC
I think the "Remove ugly debug in console" can be removed now.
Looks like that debug code is not active anymore.

W.r.t "Make O flag require P", I sent it upstream and there is
some other patches trying to handle P flag but no solution yet
Comment 6 Sergei Trofimovich (RETIRED) gentoo-dev 2019-12-19 22:48:00 UTC
Can you link your submission in this bug? (if it's visible in email archives)
Comment 7 Joakim Tjernlund 2019-12-20 10:04:43 UTC
(In reply to Sergei Trofimovich from comment #6)
> Can you link your submission in this bug? (if it's visible in email archives)

Didn't find it in using Googel but there is another competing impl:
  https://patchew.org/QEMU/20191024153847.31815-1-laurent@vivier.eu/
connected to a kernel patch:
  https://lore.kernel.org/patchwork/patch/1158151/

In any case, progress is slow upstream, one might have to push upstream a little
so what does Gentoo want to do meanwhile?

Using my patch + adding QEMU binfmt flags to OP will wil make thing just work.
Also adding F flags makes sense
Comment 8 Matthias Maier gentoo-dev 2020-03-13 17:07:14 UTC
I suggest we wait for upstream's response to the O flag require P patch.