Bug 701622

Summary:	dev-python/pygobject: version bump and add test dependencies to RDEPEND
Product:	Gentoo Linux	Reporter:	Benda Xu <heroxbd>
Component:	Current packages	Assignee:	Python Gentoo Team <python>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gnome
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	pygobject.patch

Description Benda Xu gentoo-dev

2019-12-01 03:17:36 UTC

Hi, I intend to commit the attached in a week.  Do you think it alright?

Yours,
Benda

Reproducible: Always

Comment 1 Benda Xu gentoo-dev

2019-12-01 03:20:08 UTC

Created attachment 598032 [details, diff]
pygobject.patch

Author: Benda Xu <heroxbd@gentoo.org>
Date:   Sun Dec 1 11:15:39 2019 +0800

    dev-python/pygobject: bump to 3.34.0.
    
      Add test dependencies to RDEPEND.  Without the test dependencies,
      runtime normal usage will fail, for example:
    
      python -c "from gi.repository import GdkX11"
    
    Package-Manager: Portage-2.3.79, Repoman-2.3.18

Comment 2 Mike Gilbert gentoo-dev

2019-12-01 03:36:51 UTC

NAK on this patch

From what I understand, pygobject does not need to be completely functional for all possible uses: it's designed to be usable with missing pieces.

Packages which need specific functionality should add appropriate dependencies themselves.

It may make sense to document this somehow.

Comment 3 Larry the Git Cow gentoo-dev

2019-12-01 04:26:06 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f40f31149140af428bbd7dce6ec5058b13907eb0

commit f40f31149140af428bbd7dce6ec5058b13907eb0
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2019-12-01 04:15:22 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2019-12-01 04:25:57 +0000

    x11-wm/xpra: add gtk introspection to RDEPEND.
    
    Closes: https://bugs.gentoo.org/701622
    Package-Manager: Portage-2.3.79, Repoman-2.3.18
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 x11-wm/xpra/xpra-3.0.2.ebuild | 1 +
 1 file changed, 1 insertion(+)

Comment 4 Benda Xu gentoo-dev

2019-12-01 04:28:33 UTC

Hi Mike,

(In reply to Mike Gilbert from comment #2)
> NAK on this patch
> 
> From what I understand, pygobject does not need to be completely functional
> for all possible uses: it's designed to be usable with missing pieces.
> 
> Packages which need specific functionality should add appropriate
> dependencies themselves.
> 
> It may make sense to document this somehow.

Thank you!  I see, let me close this bug and handle it in a case-by-case basis.   Documentation will come when many of us steps into this.