Summary: | sys-fs/dislocker-0.7.1-r2 : /.../config.c:59:6: error: expected identifier or ( before numeric constant | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Andreas Schürch <nativemad> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hlein, mehw.is.me |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/20264 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tbz2 logs.tbz2 sys-fs:dislocker-0.7.1-r2:20191119-231358.log temp.tbz2 sys-fs/dislocker-0.7.1-r2.ebuild patch sys-fs/dislocker-0.7.1-r2.ebuild files sys-fs/dislocker-9999.ebuild patch |
Description
Toralf Förster
2019-11-20 15:26:08 UTC
Created attachment 596894 [details]
emerge-info.txt
Created attachment 596896 [details]
emerge-history.txt
Created attachment 596898 [details]
environment
Created attachment 596900 [details]
etc.portage.tbz2
Created attachment 596902 [details]
logs.tbz2
Created attachment 596904 [details]
sys-fs:dislocker-0.7.1-r2:20191119-231358.log
Created attachment 596906 [details]
temp.tbz2
FWIW I was not able to reproduce this; dislocker-0.7.1-r2 built fine for me with various combinations of: - gcc-8.3.0-r3 - gcc-9.2.0-r2 - mbedtls-2.17.0 - mbedtls-2.19.1 - USE="-ruby" - USE="ruby" with ruby-2.4.9 - USE="ruby" with ruby-2.5.7 Created attachment 617036 [details, diff] sys-fs/dislocker-0.7.1-r2.ebuild patch Hello, I got the same error as the one in the description. I prepared patches for both dislocker-0.7.1-r2.ebuild and dislocker-9999.ebuild, which are briefly described below. dislocker-0.7.1-r2.ebuild also requires the dislocker-0.7.1-fix-find-ruby.patch to be put into the files directory. In dislocker-0.7.1-r2.ebuild only ================================= Fix compilation failure when the ruby useflag is set by replacing/adding new FindPackageHandleStandardArgs.cmake, FindPackageMessage.cmake, and FindRuby.cmake files: https://github.com/Aorimn/dislocker/commit/4596f1719b8458feca041ea26a546c37630b5e77 In both dislocker-0.7.1-r2.ebuild and dislocker-9999.ebuild =========================================================== 1. Update copyright. 2. Remove unneeded search and replace: sed 's:\.\./man:'../../${P}/man':g' -i "${S}/src/CMakeLists.txt" || die 3. Make symlink to /usr/share/man/man1/dislocker.1 rather than to /usr/share/man/man1/dislocker.1.gz 4. Fix colliding files found by ecompress: /usr/share/man/man1/dislocker-file.1 /usr/share/man/man1/dislocker-file.1.gz /usr/share/man/man1/dislocker-find.1 /usr/share/man/man1/dislocker-find.1.gz /usr/share/man/man1/dislocker-fuse.1 /usr/share/man/man1/dislocker-fuse.1.gz 5. Do not install dislocker-find.1 when the ruby useflag isn't set. Created attachment 617038 [details, diff]
sys-fs/dislocker-0.7.1-r2.ebuild files
Created attachment 617040 [details, diff]
sys-fs/dislocker-9999.ebuild patch
I forgot to mention that both sys-fs/dislocker-0.7.1-r2 and sys-fs/dislocker-9999 compile fine on my platform (amd64) with cmake/FindRuby.cmake removed from their respective source directory (I currently use dev-util/cmake-3.16.4, dev-util/ninja-1.8.2, and dev-lang/ruby-2.5.7): # export USE=ruby # cd /usr/portage/sys-fs/dislocker # ebuild dislocker-0.7.1-r2.ebuild unpack # rm /var/tmp/portage/sys-fs/dislocker-0.7.1-r2/work/dislocker-0.7.1/cmake/FindRuby.cmake # ebuild dislocker-0.7.1-r2.ebuild compile Maintainer, please use the opportunity and switch the ebuild to cmake.eclass. (In reply to mehw from comment #12) > I forgot to mention that both sys-fs/dislocker-0.7.1-r2 and > sys-fs/dislocker-9999 compile fine on my platform (amd64) with > cmake/FindRuby.cmake removed from their respective source directory Use CMAKE_REMOVE_MODULES_LIST from cmake.eclass for that. Thanks for the patches mehw! This is committed now as -r3 ebuild. Thanks all and sorry for the delay. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=68a682a2301bec17bfbd0dc887d9f490669471b0 commit 68a682a2301bec17bfbd0dc887d9f490669471b0 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2021-04-05 12:36:41 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2021-04-17 11:40:48 +0000 sys-fs/dislocker: Tidyup, DESCRIPTION w/o PN - Unnecessary ${S} - local mycmakeargs - missing || die Bug: https://bugs.gentoo.org/700784 Package-Manager: Portage-3.0.18, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> sys-fs/dislocker/dislocker-0.7.1-r3.ebuild | 21 ++++++++++----------- sys-fs/dislocker/dislocker-9999.ebuild | 21 ++++++++++----------- 2 files changed, 20 insertions(+), 22 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3d68d66d417b3d1d265ef66ac9b0089458d8ed3c commit 3d68d66d417b3d1d265ef66ac9b0089458d8ed3c Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2021-04-05 12:33:36 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2021-04-17 11:40:48 +0000 sys-fs/dislocker: Drop 0.7.1-r2, cmake-utils-- Bug: https://bugs.gentoo.org/700784 Package-Manager: Portage-3.0.18, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> sys-fs/dislocker/dislocker-0.7.1-r2.ebuild | 50 ------------------------------ 1 file changed, 50 deletions(-) |