Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 700696

Summary: games-board/gmchess-0.29.6-r2 : segmentation fault in MainWindow::MainWindow() at MainWindow.cc:161
Product: Gentoo Linux Reporter: Samuel Bauer <samuel.bauer>
Component: Current packagesAssignee: Gentoo Games <games>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH, PullRequest
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/lerosua/gmchess/issues/2
https://github.com/lerosua/gmchess/issues/3
https://github.com/gentoo/gentoo/pull/19390
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 651408    
Attachments: gmchess-0.29.6-r3.patch
gmchess segfault backtrace

Description Samuel Bauer 2019-11-19 16:33:25 UTC
Created attachment 596770 [details, diff]
gmchess-0.29.6-r3.patch

gmchess just segfaults when launching.

This patches fixes several issues:
    https://github.com/lerosua/gmchess/issues/2
    https://github.com/lerosua/gmchess/issues/3
    https://bugs.gentoo.org/show_bug.cgi?id=651408


About segfault when launching itself, gtk seems more picky on values returned by event handlers nowadays. Less warning appears at compile time, and runtime seems stable.
Patch needs to be added to the ebuild, nothing more.
Comment 1 Samuel Bauer 2019-11-20 22:10:13 UTC
Created attachment 596968 [details]
gmchess segfault backtrace

This bug description was a bit raw, here are a bit more details to help understanding.

In order being able to compile the in tree version of gmchess this patch is applied via user patches:
https://bugs.gentoo.org/attachment.cgi?id=596764

I may begin to port this nice chinese chess gui to gtkmm:3 soon.
Comment 2 Sergey Torokhov 2021-02-08 05:25:17 UTC
> This bug description was a bit raw, here are a bit more details to help
> understanding.
> 
> In order being able to compile the in tree version of gmchess this patch is
> applied via user patches:
> https://bugs.gentoo.org/attachment.cgi?id=596764

Great thanks for comulative patch. 
I only replaced "gmchess-0.29.6-r3/src/" paths with "gmchess-0.29.6/src/" but maybe fail to patch was caused by another patch that I initially added to fix compile error that offered patch already contains.


> I may begin to port this nice chinese chess gui to gtkmm:3 soon.

If there is any progress in porting?
Comment 3 Larry the Git Cow gentoo-dev 2021-02-13 13:24:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7f141b7174e0fb1730d994e12f804da50c68103

commit e7f141b7174e0fb1730d994e12f804da50c68103
Author:     Sergey Torokhov <torokhov-s-a@yandex.ru>
AuthorDate: 2021-02-09 19:40:51 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2021-02-13 13:23:47 +0000

    games-board/gmchess: fix build error and segfaults
    
    The applied patch fixes build error issue and
    some additional issues that cause segmentation fault on run
    (for more detailes see the second issue description
    in the list below).
    
    Thanks to Samuel Bauer for proposed patch.
    
    Closes: https://bugs.gentoo.org/651408
    Closes: https://bugs.gentoo.org/700696
    
    Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
    Closes: https://github.com/gentoo/gentoo/pull/19390
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 .../files/gmchess-0.29.6_fix_build_segfault.patch  | 102 +++++++++++++++++++++
 games-board/gmchess/gmchess-0.29.6-r3.ebuild       |  59 ++++++++++++
 2 files changed, 161 insertions(+)