Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 700282

Summary: sys-auth/fprintd-1.90.8 version bump
Product: Gentoo Linux Reporter: Ulf Dambacher <ulf.dambacher>
Component: Current packagesAssignee: Maxim Koltsov (RETIRED) <maksbotan>
Status: RESOLVED FIXED    
Severity: normal CC: dflogeras2, flyingwaffle, ikelos, me, prometheanfire, viz
Priority: Normal Keywords: EBUILD, PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://gitlab.freedesktop.org/libfprint/fprintd/-/tags
See Also: https://github.com/gentoo/gentoo/pull/15248
https://github.com/gentoo/gentoo/pull/18601
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: fprintd-0.9.0.ebuild
0.9.0 ebuild with SRC_URI fixed and path patched
new ebuild with fixes according to comment #5
do correct --with-systemdsystemunitdir
updated ebuild
live ebuild
ebuild for v1.90.5
additional patches for ebuild
additional patches for ebuild (2)
additional patches for ebuild (3)

Description Ulf Dambacher 2019-11-16 20:19:21 UTC
with fprintd-0.8.1-r1 and libfprint-1.0. I could enroll a fingerprint with fprintd-enroll and it succeded but the data was not stored and fprintd-list shows up with no fingerprints ergistered.

I checked version 0.9.0 and it works correctly - ebuild enclosed.



Reproducible: Always

Steps to Reproduce:
1. execute fprintd-enroll and register any fingerprint
2. execute fprintd-list and observe that there is no prints registered

Actual Results:  
no files in /var/lib/fprint

Expected Results:  
new fingerprints in /var/lib/fprint
Comment 1 Ulf Dambacher 2019-11-16 20:20:29 UTC
Created attachment 596436 [details]
fprintd-0.9.0.ebuild

ebuild for new version 0.9.0
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2019-11-17 10:17:10 UTC
Comment on attachment 596436 [details]
fprintd-0.9.0.ebuild

--- sys-auth/fprintd/fprintd-0.8.1-r1.ebuild
+++ sys-auth/fprintd/fprintd-0.9.0.ebuild
@@ -35,6 +35,7 @@
        default

        sed -i 's#@localstatedir@/lib/fprint#@localstatedir@/fprint#g' data/fprintd.service.in || die "sed failed"
+       sed -i 's#(localstatedir)/lib/fprint#(localstatedir)/fprint#g' src/Makefile.am || die "sed failed"
        eautoreconf
 }
Comment 3 Andrew Udvare 2019-11-21 05:20:36 UTC
Jeroen, is that patch fixing that the data would get stored into /var/lib/lib/fprint rather than the correct place?

I have this with the current version:

 $ strings /usr/libexec/fprintd | fgrep var
/var/lib/lib/fprint

I was able to figure out the issue by manually running fprintd.
Comment 4 Viz 2020-01-03 19:55:40 UTC
Created attachment 602428 [details]
0.9.0 ebuild with SRC_URI fixed and path patched

Note the old SRC_URI no longer works, attached a new ebuild
Comment 5 Peter Gantner (a.k.a. nephros) 2020-04-06 12:59:33 UTC
(In reply to Viz from comment #4)
> Created attachment 602428 [details]
> 0.9.0 ebuild with SRC_URI fixed and path patched


Just tested this.

Using the  --with-systemdsystemunitdir configure parameter causes a check for an installed systemd.

So:

 - add systemd USE flag
 - add systemd to DEPEND if it is set
 - wrap the configure call so  --with-systemdsystemunitdir is only done if the flag is set

(Also, 0.9.0 is also affected by #704158)
Comment 6 Ulf Dambacher 2020-04-06 16:54:52 UTC
Find an ebuild for version 1.90.1 on my github repo
This builds with meson.

https://github.com/ulda/gentoo-ulda/tree/master/sys-auth/fprintd
Comment 7 Ulf Dambacher 2020-04-06 17:44:27 UTC
Created attachment 630870 [details]
new ebuild with fixes according to comment #5
Comment 8 Ulf Dambacher 2020-04-06 18:32:22 UTC
Created attachment 630878 [details]
do correct --with-systemdsystemunitdir
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2020-07-05 19:16:41 UTC
*** Bug 730954 has been marked as a duplicate of this bug. ***
Comment 10 Jeroen Roovers (RETIRED) gentoo-dev 2020-07-05 19:17:00 UTC
*** Bug 717174 has been marked as a duplicate of this bug. ***
Comment 11 FlyingWaffle 2020-07-05 19:33:29 UTC
Created attachment 647848 [details]
updated ebuild

Should resolve.
Note that systemd is now a hard dependency unless someone can spin out a "libsystemd" ebuild to account for systemd's new dbus library.
I'm also not 100% sure that my ebuild removes the need for tests, in which case an ebuild for pam_wrapper is also needed.  I do have a working ebuild for that however, which I'll post shortly.
Comment 12 FlyingWaffle 2020-07-05 19:34:17 UTC
Created attachment 647850 [details]
live ebuild

Live ebuild in case anyone wants it.
Same caveats as my prior comment.
Comment 13 FlyingWaffle 2020-07-05 19:43:50 UTC
pam_wrapper ebuild here: https://bugs.gentoo.org/730974
if anyone wants to drop it into their localrepo.
Comment 14 mr_happy_hof 2020-10-20 12:11:24 UTC
I have created a working ebuild for fprintd-1.90.1 which works with openrc and elogind. No systemd dependency. I would be happy if you could test it.

I have it in my private overlay: https://github.com/mrhappyhof/mrhappyhof-gentoo/
Comment 15 mr_happy_hof 2020-10-20 12:15:18 UTC
(In reply to mr_happy_hof from comment #14)
> I have created a working ebuild for fprintd-1.90.1 which works with openrc
> and elogind. No systemd dependency. I would be happy if you could test it.
> 
> I have it in my private overlay:
> https://github.com/mrhappyhof/mrhappyhof-gentoo/

It doesnt work with systemd.
Comment 16 Ulf Dambacher 2020-12-06 08:44:28 UTC
Its now at version v1.90.5
Comment 17 Ulf Dambacher 2020-12-06 13:08:04 UTC
Created attachment 677005 [details]
ebuild for v1.90.5

you need the patches, too
included elogind support as suggested by mr_happy_hof, but untested.

find it in https://github.com/ulda/gentoo-ulda
Comment 18 Ulf Dambacher 2020-12-06 13:08:58 UTC
Created attachment 677008 [details, diff]
additional patches for ebuild
Comment 19 Ulf Dambacher 2020-12-06 13:09:23 UTC
Created attachment 677011 [details, diff]
additional patches for ebuild (2)
Comment 20 Ulf Dambacher 2020-12-06 13:09:41 UTC
Created attachment 677014 [details, diff]
additional patches for ebuild (3)
Comment 21 Ulf Dambacher 2020-12-11 07:21:58 UTC
another version bump to 1.90.7

bearsch did a new ebuild and pull request.
see also: 
https://github.com/bearsh/gentoo/tree/sys-auth/fprintd/sys-auth/fprintd

this is working for me (with systemd)
Comment 22 Martin Gysel (bearsh) 2020-12-11 08:09:42 UTC
is there anyone with elogind to test?

btw, thanks Ulf/mr_happy_hof for your ebuild for the elogind support
Comment 23 Ulf Dambacher 2020-12-13 07:45:03 UTC
.. and there comes .8
Somebody is removing regressions fast there...

I updated the .7 ebuild to .8 , find it in my repository
https://github.com/ulda/gentoo-ulda
Comment 24 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2021-01-08 17:13:48 UTC
version bump done, thanks  I think there was one minor change (using the new slots for libfprint) but that was it :D
Comment 25 Martin Gysel (bearsh) 2021-01-11 06:49:34 UTC
(In reply to Matthew Thode ( prometheanfire ) from comment #24)
> version bump done, thanks  I think there was one minor change (using the new
> slots for libfprint) but that was it :D

well that change was already included in the PR on github...
anyway, thanks for bumping, I'll close the PR manually