Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 699958

Summary: app-accessibility/at-spi2-core-2.34.0 : add optional support for dbus-broker
Product: Gentoo Linux Reporter: Chris Mayo <aklhfex>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: ibuyandtrade0+bugs.gentoo.org
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Chris Mayo 2019-11-12 19:54:06 UTC 
Currently at-spi2-core will start sys-apps/dbus's dbus-daemon but it can now optionally use dbus-broker:

https://gitlab.gnome.org/GNOME/at-spi2-core/commit/d7f47c99d093ba91eb18523e14b23bde1794f5bc

Configured with:

-Ddefault_bus=dbus-broker


Looks like sys-apps/dbus is still a build-time dependency:

registryd/registry.h:30:#include <dbus/dbus.h>
registryd/registry-main.c:32:#include <dbus/dbus.h>

with sys-apps/dbus-broker only needed at run time.

The patch below does work for me, although I don't know if [${MULTILIB_USEDEP}] is needed for an RDEPEND on an executable.

--- at-spi2-core-2.34.0.ebuild
+++ at-spi2-core-2.34.0-r1.ebuild
@@ -10,10 +10,10 @@
 
 LICENSE="LGPL-2+"
 SLOT="2"
-IUSE="X gtk-doc +introspection"
+IUSE="X dbus-broker gtk-doc +introspection"
 KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~s390 ~sparc ~x86 ~amd64-linux ~x86-linux ~x64-macos ~x86-macos"
 
-RDEPEND="
+DEPEND="
 	>=sys-apps/dbus-1.5[${MULTILIB_USEDEP}]
 	>=dev-libs/glib-2.36:2[${MULTILIB_USEDEP}]
 	introspection? ( >=dev-libs/gobject-introspection-1.54.0:= )
@@ -23,7 +23,9 @@
 		x11-libs/libXi[${MULTILIB_USEDEP}]
 	)
 "
-DEPEND="${RDEPEND}"
+RDEPEND="${DEPEND}
+	dbus-broker? ( sys-apps/dbus-broker )
+"
 BDEPEND="
 	dev-util/glib-utils
 	gtk-doc? (
@@ -41,6 +43,7 @@
 multilib_src_configure() {
 	local emesonargs=(
 		-Dsystemd_user_dir="$(systemd_get_userunitdir)"
+		-Ddefault_bus=$(usex dbus-broker dbus-broker dbus-daemon)
 		-Ddocs=$(multilib_native_usex gtk-doc true false)
 		-Dintrospection=$(multilib_native_usex introspection)
 		-Dx11=$(usex X)
Comment 1 Larry the Git Cow gentoo-dev 2023-05-30 15:53:21 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79dbf2b0ddea6443fdac6d7a7b28051103d76aa5

commit 79dbf2b0ddea6443fdac6d7a7b28051103d76aa5
Author:     Guillermo Joandet <gjoandet@gmail.com>
AuthorDate: 2023-05-27 17:09:11 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-05-30 15:51:32 +0000

    app-accessibility/at-spi2-core: Version bump to 2.48.3
    
    Closes: https://bugs.gentoo.org/699958
    Closes: https://github.com/gentoo/gentoo/pull/31187
    Signed-off-by: Guillermo Joandet <gjoandet@gmail.com>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 app-accessibility/at-spi2-core/Manifest            |  1 +
 .../at-spi2-core/at-spi2-core-2.48.3.ebuild        | 75 ++++++++++++++++++++++
 app-accessibility/at-spi2-core/metadata.xml        |  3 +
 profiles/arch/alpha/package.use.mask               |  4 ++
 profiles/arch/arm/package.use.mask                 |  4 ++
 profiles/arch/hppa/package.use.mask                |  4 ++
 profiles/arch/ia64/package.use.mask                |  4 ++
 profiles/arch/loong/package.use.mask               |  4 ++
 profiles/arch/mips/package.use.mask                |  4 ++
 profiles/arch/powerpc/ppc32/package.use.mask       |  4 ++
 profiles/arch/riscv/package.use.stable.mask        |  6 ++
 profiles/arch/s390/package.use.mask                |  4 ++
 profiles/arch/sparc/package.use.mask               |  4 ++
 profiles/arch/x86/package.use.mask                 |  4 ++
 profiles/features/musl/package.use.mask            |  4 ++
 15 files changed, 129 insertions(+)