Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 69944

Summary: The ebuild doesnt check if omnibook.o or .ko has to be copied
Product: Gentoo Linux Reporter: Tom A. Bergmann <botas>
Component: New packagesAssignee: Mobile Herd (OBSOLETE) <mobile+disabled>
Status: RESOLVED FIXED    
Severity: blocker    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Tom A. Bergmann 2004-11-03 07:14:49 UTC
in the last ebuild (omnibook-20040701.ebuild) there is in src_install():
doins omnibook.o || die

it doesn't check if it should copy omnibook.o for kernels < 2.5 or omnibook.ko for  kernels >= 2.5

if you replace the line with:
        if [[ "${KV}" > "2.5" ]] ; then
          doins omnibook.ko
        else
          doins omnibook.o
        fi
it seems to work.
I don't know if this is the right way. It's only copy & past.

Thanks, I hope to reach the right persons here.

Reproducible: Always
Steps to Reproduce:
1. emerge omnibook with kernelverion 2.6

Actual Results:  
the wrong kernel module is copyed to /lib/modules/... 

Expected Results:  
it should have copyed the .ko file (instead of .o)

 emerge info
Portage 2.0.51_rc7 (default-x86-2004.0, gcc-3.4.2, glibc-2.3.4.20040808-r1,
2.6.9-rc3 i686)
=================================================================
System uname: 2.6.9-rc3 i686 Intel(R) Pentium(R) III Mobile CPU      1133MHz
Gentoo Base System version 1.5.3
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.92.0.2
Headers:  sys-kernel/linux26-headers-2.6.8.1-r1
Libtools: sys-devel/libtool-1.5.2-r5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-mtune=pentium3 -march=pentium3 -O3 -pipe -fprefetch-loop-arrays
-funroll-loops -fpeel-loops -funswitch-loops -fomit-frame-pointer -mmmx -msse"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.2/share/config
/usr/kde/3.3/share/config:/usr/kde/3.3/env:/usr/kde/3.3/shutdown
/usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-mtune=pentium3 -march=pentium3 -O3 -pipe -fprefetch-loop-arrays
-funroll-loops -fpeel-loops -funswitch-loops -fomit-frame-pointer -mmmx -msse"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache distlocks sandbox"
GENTOO_MIRRORS="ftp://mir.zyrianes.net/gentoo/ http://mir.zyrianes.net/gentoo/
http://mirror.gentoo.no/ http://www.gigaload.org/gentoo.org/
http://194.149.10.102/ ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo
http://195.56.77.10/ ftp://mirror.nutsmaas.nl/gentoo/
ftp://ftp.heanet.ie/pub/gentoo/
http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/
ftp://ftp.snt.utwente.nl/pub/os/linux/gentoo http://gentoo.inode.at/
ftp://ftp.tu-clausthal.de/pub/linux/gentoo/
http://ftp.snt.utwente.nl/pub/os/linux/gentoo http://ftp.heanet.ie/pub/gentoo/
ftp://gd.tuwien.ac.at/opsys/linux/gentoo/ http://gentoo.spb.ru/rsync
ftp://mirrors1.netvisao.pt/gentoo/
http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/
ftp://linux.rz.ruhr-uni-bochum.de/gentoo-mirror/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/myportage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aalib acpi alsa apache2 apm arts avi berkdb bitmap-fonts bonobo cdr crypt
cups dba dga divx dumb-allegro dvd emacs-w3 encode esd f77 fbcon foomaticdb gd
gdbm gif gimpprint gnome gpm gtk gtk2 gtkhtml guile i830 i8x0 imlib java
javascript jikes jpeg kde libg++ libwww mad mikmod mmx motif mozilla mpeg mysql
ncurses nls nptl offensive oggvorbis opengl oss pam pdflib perl png ppds python
qt quicktime readline samba sdl slang spell sse ssl svga tcpd tetex tiff
truetype usb x86 xml2 xmms xv xvid zlib video_cards_i830"
Comment 1 Stefan Schweizer (RETIRED) gentoo-dev 2004-11-15 10:34:16 UTC
Fixed, thanks.