| Summary: | net-wireless/iwd ebuild quality issues | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Mike Gilbert <floppym> |
| Component: | Current packages | Assignee: | Ben Kohler <bkohler> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bkohler |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/13518 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a6d9d4fb599177e4e935a0b935d525c512d1c418 commit a6d9d4fb599177e4e935a0b935d525c512d1c418 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2019-11-01 15:15:50 +0000 Commit: Ben Kohler <bkohler@gentoo.org> CommitDate: 2019-11-01 16:22:55 +0000 net-wireless/iwd: fetch ell.git using git-r3 Bug: https://bugs.gentoo.org/699042 Package-Manager: Portage-2.3.78_p4, Repoman-2.3.17_p100 Signed-off-by: Mike Gilbert <floppym@gentoo.org> Signed-off-by: Ben Kohler <bkohler@gentoo.org> net-wireless/iwd/iwd-9999.ebuild | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2a6e1b53a535590713a205764b7c0f43b8d456e5 commit 2a6e1b53a535590713a205764b7c0f43b8d456e5 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2019-11-01 15:03:24 +0000 Commit: Ben Kohler <bkohler@gentoo.org> CommitDate: 2019-11-01 16:22:55 +0000 net-wireless/iwd: pass EPREFIX where appropriate Bug: https://bugs.gentoo.org/699042 Package-Manager: Portage-2.3.78_p4, Repoman-2.3.17_p100 Signed-off-by: Mike Gilbert <floppym@gentoo.org> Signed-off-by: Ben Kohler <bkohler@gentoo.org> net-wireless/iwd/iwd-9999.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef332c239ad8db53cb36a95ee7e7c474507bf03e commit ef332c239ad8db53cb36a95ee7e7c474507bf03e Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2019-11-01 15:01:57 +0000 Commit: Ben Kohler <bkohler@gentoo.org> CommitDate: 2019-11-01 16:22:55 +0000 net-wireless/iwd: skip eautoreconf for release builds Bug: https://bugs.gentoo.org/699042 Package-Manager: Portage-2.3.78_p4, Repoman-2.3.17_p100 Signed-off-by: Mike Gilbert <floppym@gentoo.org> Signed-off-by: Ben Kohler <bkohler@gentoo.org> net-wireless/iwd/iwd-9999.ebuild | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a039614386b3d371c93b6bbc5537919fb3498568 commit a039614386b3d371c93b6bbc5537919fb3498568 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2019-11-01 14:59:24 +0000 Commit: Ben Kohler <bkohler@gentoo.org> CommitDate: 2019-11-01 16:22:55 +0000 net-wireless/iwd: improve kernel checks Bug: https://bugs.gentoo.org/699042 Package-Manager: Portage-2.3.78_p4, Repoman-2.3.17_p100 Signed-off-by: Mike Gilbert <floppym@gentoo.org> Signed-off-by: Ben Kohler <bkohler@gentoo.org> net-wireless/iwd/iwd-9999.ebuild | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Only remaining issue now is the use of a private systemd.eclass function The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bba175a2ce817e84cd02575961f78f60c6627227 commit bba175a2ce817e84cd02575961f78f60c6627227 Author: Ben Kohler <bkohler@gentoo.org> AuthorDate: 2019-11-01 19:42:39 +0000 Commit: Ben Kohler <bkohler@gentoo.org> CommitDate: 2019-11-01 19:43:02 +0000 net-wireless/iwd: stop using private systemd.eclass function Just hardcode the modules-load.d dir instead of abusing a private eclass function. Closes: https://bugs.gentoo.org/699042 Package-Manager: Portage-2.3.78, Repoman-2.3.17 Signed-off-by: Ben Kohler <bkohler@gentoo.org> net-wireless/iwd/iwd-9999.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |
I noticed a few problems while reading through the ebuild for net-wireless/iwd. 1. src_configure calls the private function _systemd_get_dir from systemd.eclass. The eclass should be extended with a proper public function for the modulesloaddir setting instead. 2. pkg_pretend calls getfilevar with a hard-coded path of /usr/src/linux/.config. The kernel build directory may not be present at this location. Please use the linux_config_exists, linux_chkconfig_builtin, and linux_chkconfig_string functions instead. 3. The ebuild inherits autotools and calls eautoreconf unconditionally. Unless upstream ships broken tarballs, this should only be necessary if the ebuild patches autotools infrastructure (configure.ac/Makefile.am). It would also be necessary in the live ebuild. 4. src_unpack calls git-clone directly to fetch some related repository. Please utilize git-r3_fetch and git-r3_checkout for this instead. 5. src_configure passes --sysconfdir=/etc/iwd to econf. Please use "${EPREFIX}/etc/iwd" instead.