| Summary: | [FIXED]sys-libs/glibc-2.3.4.20041021 - include/features.h needs patching | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Imad R. Faiad <irfaiad> |
| Component: | [OLD] Core system | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
| Status: | RESOLVED INVALID | ||
| Severity: | normal | CC: | dberkholz, lv |
| Priority: | High | ||
| Version: | 2004.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 69395 | ||
| Attachments: |
glibc-2.3.4-branch-update-20041021.patch-features.h.patch
Alternate patch directly on include/features.h Patch on include/features.h that gets rid of numerical comparison |
||
Created attachment 43161 [details]
glibc-2.3.4-branch-update-20041021.patch-features.h.patch
a patch to glibc-2.3.4-branch-update-20041021.patch
to fix the above problem.
Created attachment 43163 [details]
Alternate patch directly on include/features.h
an alternate patch to be applied directly on include/features.h after applying
the glibc-2.3.4-branch-update-20041021.patch.
hth
here is the emerge info: gentoo3 ~ # emerge info Portage 2.0.51-r2 (default-linux/x86/2004.3, gcc-3.3.5, glibc-2.3.4.20041021-r0, 2.6.8-gentoo-r10 i686) ================================================================= System uname: 2.6.8-gentoo-r10 i686 Intel(R) Pentium(R) 4 CPU 3.20GHz Gentoo Base System version 1.6.5 distcc 2.17 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [enabled] ccache version 2.3 [enabled] Autoconf: sys-devel/autoconf-2.59-r5 Automake: sys-devel/automake-1.8.5-r1 Binutils: sys-devel/binutils-2.15.92.0.2-r1 Headers: sys-kernel/linux26-headers-2.6.8.1-r1 Libtools: sys-devel/libtool-1.5.2-r5 ACCEPT_KEYWORDS="x86 ~x86" AUTOCLEAN="yes" CFLAGS="-march=pentium4 -O2 -mfpmath=sse -msse2 -fomit-frame-pointer" CHOST="i686-pc-linux-gnu" COMPILER="" CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-march=pentium4 -O2 -mfpmath=sse -msse2 -fomit-frame-pointer" DISTDIR="/mnt/sda4/distfiles" FEATURES="autoaddcvs buildpkg ccache distcc distlocks sfperms" GENTOO_MIRRORS="http://gentoo.oregonstate.edu" MAKEOPTS="-j7" PKGDIR="/mnt/sda4/shared/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://134.68.220.73/gentoo-portage" USE="X alsa arts avi berkdb bitmap-fonts cdr crypt dvd encode esd f77 fam flac foomaticdb gdbm gif gnome gpm gstreamer gtk gtk2 idea imlib java jpeg kde libg++libwww mad mikmod motif mozilla mpeg ncurses nls nptl nptlonly oggvorbis opengloss pam pdflib perl png python qt quicktime readline samba sdl slang spell ssl svga tcpd tetex tiff truetype x86 xml2 xmms xv zlib" please file this bug upstream: http://sources.redhat.com/bugzilla/ Fun, this means I can't compile app-arch/tar. nevermind. filed upstream: http://sources.redhat.com/bugzilla/show_bug.cgi?id=496 once the glibc-2.3.3-75 src rpm appears in the fedora srpm directory (it's already tagged in cvs), i'll do a new ebuild including this fix. ...or not, since i still cant compile tar 1.14.90 with this. i tested against 1.14 :| bah Created attachment 43228 [details, diff]
Patch on include/features.h that gets rid of numerical comparison
The first patch didn't solve the problem for me. It seems that __OPTIMIZE__ is
#defined without being assigned a value, so the numerical comparison fails.
This patch worked for me, though (I was able to compile tar).
Worked for me too. |
greetings lv, include/features.h of glibc-2.3.4-branch-update-20041021 needs patching, the problems is at line 265, which reads as follows: #if _FORTIFY_SOURCE > 0 && __OPTIMIZE__ > 0 \ however, the above should read as follows: #if (_FORTIFY_SOURCE > 0) && (__OPTIMIZE__ > 0) \ test case: emerge app-arch/tar-1.14.90-r1 will yield the following error: i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -march=pentium4 -O2 -mfpmath=sse -msse2 -fomit-frame-pointer -c xstrtoumax.c In file included from /usr/include/stdio.h:28, from argp-fmtstream.h:32, from argp-fs-xinl.c:27: /usr/include/features.h:265:41: operator '&&' has no right operand distcc[10836] ERROR: compile argp-fs-xinl.c on localhost failed make[3]: *** [argp-fs-xinl.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: Leaving directory `/var/tmp/portage/tar-1.14.90-r1/work/tar-1.14.90/lib' make[2]: *** [all] Error 2 make[2]: Leaving directory `/var/tmp/portage/tar-1.14.90-r1/work/tar-1.14.90/lib' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/tar-1.14.90-r1/work/tar-1.14.90' make: *** [all] Error 2 !!! ERROR: app-arch/tar-1.14.90-r1 failed. !!! Function src_compile, Line 44, Exitcode 2 !!! emake failed !!! If you need support, post the topmost build error, NOT this status message.