Bug 697602 – x11-libs/gdk-pixbuf does not regenerate loaders.cache

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description dkjii 2019-10-13 07:37:38 UTC]

When building gdk-pixbuf, it does not regenerate  /usr/lib64/gdk-pixbuf-2.0/2.10.0/loaders.cache, which means any change in useflag (e.g. adding/removing jpeg/tiff) will not work

Problem seems to be that GNOME2_ECLASS_GDK_PIXBUF_LOADERS is not set, so the updating of the cache is skipped (from the gnome2-utils eclass)

Not familiar enough to suggest a fix

Reproducible: Always

Steps to Reproduce:
1. USE=-jpeg emerge -1 x11-libs/gdk-pixbuf
2. gdk-pixbuf-query-loaders --update-cache
2. USE=jpeg emerge -1 x11-libs/gdk-pixbuf
3. gdk-pixbuf-thumbnailer randomjpeg.jpg /tmp/thumb
Actual Results:  
No /tmp/thumb, warning about unrecognized file type (cache does not change on step 3)

Expected Results:  
Thumbnail at /tmp/thump (cache is regenerated after emerge)

tested on gdk-pixbuf-2.38.1.ebuild, but gdk-pixbuf-2.38.2.ebuild does not look like it changed anything relevent

[Comment 1 Mart Raudsepp 2019-10-13 07:42:36 UTC]

Looks like me misreading and thinking explicit gnome2_gdk_pixbuf_update will work, when in this case it's actually doing the check in itself, not in gnome2.eclass like was done for icon cache and other things; so a regression from porting to meson and dropping gnome2.eclass usage (missing gnome2_gdk_pixbuf_savelist call)

[Comment 2 Larry the Git Cow 2019-10-13 11:27:10 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f7fc258f5d09d73e9e46541d8d6d010a0240f51

commit 7f7fc258f5d09d73e9e46541d8d6d010a0240f51
Author:     Mart Raudsepp <[e-mail]>
AuthorDate: 2019-10-13 11:23:17 +0000
Commit:     Mart Raudsepp <[e-mail]>
CommitDate: 2019-10-13 11:26:13 +0000

    x11-libs/gdk-pixbuf: loaders.cache update fixes (thumbnailing, etc)
    
    Fix regressions from meson port for gdk-pixbuf loaders.cache updating.
    
    * Add missing gnome2_gdk_pixbuf_savelist call to pkg_preinst for stable
      version, revbumped straight to stable to fix any outdated caches
      for stable users, as it could be causing lack of thumbnailing
      functionality and other issues.
    * Add it to ~arch version too, but also downgrade it back to EAPI-7,
      as gnome2-utils.eclass is broken for EAPI-7 still for gdk-pixbuf
      cache updating (missing eutils inherit from emktemp usage and
      broken $ED and $EROOT lack of ending slash handling. Though instead
      of full revert of the changes, convert the ebuilds own $ED and
      $EROOT handling to be EAPI agnostic for now.
    * Drop ancient migration log in the ~arch revbump that seems to have
      been for a time when gdk-pixbuf was newly introduced over a decade
      or more ago (when split out of gtk2 in its early days).
    
    Closes: https://bugs.gentoo.org/697602
    Package-Manager: Portage-2.3.69, Repoman-2.3.12
    Signed-off-by: Mart Raudsepp <[e-mail]>

 ...buf-2.38.1.ebuild => gdk-pixbuf-2.38.1-r1.ebuild} |  1 +
 ...buf-2.38.2.ebuild => gdk-pixbuf-2.38.2-r1.ebuild} | 20 ++++++++------------
 2 files changed, 9 insertions(+), 12 deletions(-)