Bug 697514

Summary:	games-puzzle/gweled: segmentation fault in ? at ? and needs this patch to workaround gnome-base/librsvg bug?
Product:	Gentoo Linux	Reporter:	Ben <blc+gentoo>
Component:	Current packages	Assignee:	Gentoo Games <games>
Status:	RESOLVED FIXED
Severity:	major	CC:	gentoo.wayne, gentoo, jstein
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugs.launchpad.net/gweled/+bug/1869038
See Also:	https://gitlab.gnome.org/GNOME/librsvg/issues/198
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	648990
Bug Blocks:
Attachments:	suggested patch from other forum to workaround librsvg bug

Description Ben 2019-10-11 20:14:09 UTC

Created attachment 592534 [details, diff]
suggested patch from other forum to workaround librsvg bug

games-puzzle/gweled-0.9.1-r2 (~) segfaults on startup before opening first window.

f.g.o discussion: https://forums.gentoo.org/viewtopic-t-1101536.html

Launchpad discussion: https://bugs.launchpad.net/gweled/+bug/1741664

It looks like it has been rootcaused to be due to a librsvg bug that gweled abuses to crash.  >=librsvg-2.42.3 (not currently in portage) fixes the bug, or a patch can be applied to gweled to deal with the broken librsvg.  The patch copied/attached/tested here also improves gweled error handling regardless of librsvg used.

Applying the patch, the game seems to now play correctly with the current gnome-base/librsvg-2.40.20 (tested on amd64, x86)

Comment 1 Kobboi 2020-08-16 21:21:08 UTC

(gweled:61715): librsvg-CRITICAL **: 23:20:32.426: rsvg_pixbuf_from_file_at_size: assertion 'error.is_null() || (*error).is_null()' failed
Segmentation fault (core dumped)

With librsvg-2.48.8

Comment 2 Jonas Stein gentoo-dev

2020-09-19 19:00:35 UTC

confirming the core dump

Comment 3 Jonas Stein gentoo-dev

2020-09-19 19:07:14 UTC

Tested with gnome-base/librsvg-2.48.8 where this bug should be fixed
and games-puzzle/gweled-0.9.1-r2 still segfaults.

Comment 4 Jonas Stein gentoo-dev

2022-10-13 20:26:43 UTC

*** Bug 876703 has been marked as a duplicate of this bug. ***

Comment 5 Ben 2022-10-14 14:44:16 UTC

Yeah, looks like upstream really needs to apply the patch that more cleanly handles/checks error conditions.  Has gweled been abandoned upstream?

I just checked, the patch appears to be needed for gweled-0.9.1-r2, even with librsvg-2.52.6.

Comment 6 Larry the Git Cow gentoo-dev

2022-11-11 08:27:02 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5250193d6c3d1d50af1973a9925c95065e568511

commit 5250193d6c3d1d50af1973a9925c95065e568511
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2022-11-11 07:02:16 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-11-11 08:26:31 +0000

    games-puzzle/gweled: EAPI6->8, fix startup, icons, clang16
    
    Also:
    * GPL-2 -> GPL-2+
    * replace dead HOMEPAGE
    * remove -Wl,--export-dynamic, this used to fix a glade issue
      but glade is no longer used
    * use gamestat, hopefully letting scores work (untested)
    * drop unnecessary gentoo.patch, replace by --localstatedir
    
    May still be a bit finnicky, but is not completely unusable.
    
    Closes: https://bugs.gentoo.org/697514
    Closes: https://bugs.gentoo.org/830532
    Closes: https://bugs.gentoo.org/874738
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 .../gweled/files/gweled-0.9.1-gentoo.patch         | 11 -----
 .../gweled/files/gweled-0.9.1-implicit-decl.patch  | 15 ++++++
 .../gweled/files/gweled-0.9.1-librsvg.patch        | 45 ++++++++++++++++++
 games-puzzle/gweled/gweled-0.9.1-r2.ebuild         | 37 ---------------
 games-puzzle/gweled/gweled-0.9.1-r3.ebuild         | 54 ++++++++++++++++++++++
 5 files changed, 114 insertions(+), 48 deletions(-)