Summary: | www-servers/nginx-unit: does not respect CC/AR | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Ralph Seichter <gentoo> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | CC: | proxy-maint |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://github.com/gentoo/gentoo/pull/13417 https://github.com/gentoo/gentoo/pull/13508 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 243502 |
Description
Agostino Sarubbo
2019-10-08 15:06:36 UTC
If the summary is not enough clear: nginx-unit does not respect CC and AR variables. See the tracker and the other bugs that blocks the tracker for major info. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=424ed4537c26ea62a23bb040e691477ac1bc0e1b commit 424ed4537c26ea62a23bb040e691477ac1bc0e1b Author: Ralph Seichter <github@seichter.de> AuthorDate: 2019-10-24 18:34:17 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-10-28 06:39:36 +0000 www-servers/nginx-unit: Build related bug fixes This ebuild addresses CFLAGS/LDFLAGS issues and introduces a USE flag for OpenSSL support. Closes: https://bugs.gentoo.org/696964 Closes: https://bugs.gentoo.org/696966 Closes: https://bugs.gentoo.org/696972 Package-Manager: Portage-2.3.76, Repoman-2.3.16 Signed-off-by: Ralph Seichter <gentoo@seichter.de> Closes: https://github.com/gentoo/gentoo/pull/13417 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-servers/nginx-unit/nginx-unit-1.12.0-r1.ebuild | 72 ++++++++++++++++++++++ 1 file changed, 72 insertions(+) Hello Ralph, I tested www-servers/nginx-unit-1.12.0-r1::gentoo and the bug does not look to be fixed, here is an example from the build log: cc -c -pipe -fPIC -fvisibility=hidden -O -W -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wmissing-prototypes -Werror -g -I src -I build \ \ \ -o build/src/nxt_lib.o \ -MMD -MF build/src/nxt_lib.dep -MT build/src/nxt_lib.o \ src/nxt_lib.c ar -r -c build/libnxt.a \ As this is similar to issue https://bugs.gentoo.org/696966 and I don't want to copy and paste comments, please see my remarks there. Upstream has since agreed to add $AR support. Until that change becomes available, my updated ebuild patches the autoconf files. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0264d76cab957b25e3561c40bb45a738f38bc702 commit 0264d76cab957b25e3561c40bb45a738f38bc702 Author: Ralph Seichter <github@seichter.de> AuthorDate: 2019-10-31 16:25:48 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-11-04 05:34:08 +0000 www-servers/nginx-unit: Support AR build variable The upstream build currently does not support $AR. This ebuild patches autoconf files to remedy the issue. Closes: https://bugs.gentoo.org/696964 Package-Manager: Portage-2.3.76, Repoman-2.3.16 Signed-off-by: Ralph Seichter <gentoo@seichter.de> Closes: https://github.com/gentoo/gentoo/pull/13508 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-servers/nginx-unit/files/auto-make.patch | 14 +++ www-servers/nginx-unit/files/auto-os-conf.patch | 109 +++++++++++++++++++++ www-servers/nginx-unit/nginx-unit-1.12.0-r3.ebuild | 79 +++++++++++++++ 3 files changed, 202 insertions(+) It still calls cc directly. cc -c -fPIC -I src -I build \ \ \ -o build/src/nxt_lib.o \ -MMD -MF build/src/nxt_lib.dep -MT build/src/nxt_lib.o \ src/nxt_lib.c (In reply to Agostino Sarubbo from comment #9) > It still calls cc directly. I don't know how you call the build, but according to the build logs it works for me. Since I have spent too much time on this already, feel free to send me patches to this build and I will evaluate them. It is enough to do export CC="$(tc-getCC)" in the same place you did for AR. While the upstream developers have declined to cater for all of Gentoo's "special needs", they have accepted my request to add $AR support in future builds (see https://hg.nginx.org/unit/rev/944efece387a). |