Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 6969

Summary: qpkg -c needs to handle spaces in filenames
Product: Portage Development Reporter: Ole Tange <bugs.gentoo.org>
Component: ToolsAssignee: Portage Tools Team <tools-portage>
Status: RESOLVED FIXED    
Severity: minor CC: bugs-janitor, lostlogic, mholzer
Priority: High Keywords: InVCS
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: fixes spaces in filenames for qpkg -l
Fixes handling of wildcard in filenames in qpkg -c -v

Description Ole Tange 2002-08-24 04:37:41 UTC
I am not sure if this is really a bug. 
 
I emerged lcms. Immediately after emerge I did a qpkg -c. Now I would expect 
qpkg to say: "Everything is fine" as lcms had just been installed the second 
before. However, qpkg says: 
 
media-libs/lcms-1.09 * 
/usr/share/lcms/profiles/sRGB !not exist! 
1/30 
 
I am sure this is not a major error. But I would like to know: is it of any use 
to report situations like this as a bug (I have a whole list of packages that 
exhibit the same behaviour: qpkg -c does not check out immediately after 
install)?
Comment 1 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2002-08-27 14:00:18 UTC
I'm giving this one to Brandon, as he's the qpkg maintainer.
Comment 2 Brandon Low (RETIRED) gentoo-dev 2002-09-02 22:30:03 UTC
this is caused because there are spaces in filenames, added to the qpkg todo list
Comment 3 Martin Holzer (RETIRED) gentoo-dev 2003-01-09 16:02:04 UTC
media-libs/lcms-1.09 *
1/30

i don't get this error

/usr/share/lcms/profiles/sRGB Color Space Profile.icm still exists
Comment 4 Ole Tange 2003-03-31 02:18:55 UTC
It seems the problem is in the following section. I am not sure how to write the following 
in shell. 
 
# need to take ${line[1..n-2]} instead 
                        name=${line[1]} 
 
 
                        missing= 
                        [ ! -e ${name} ] && missing=1 
 
                        # colorize name and compute mtime/md5 
                        if [ "obj" = ${line[0]} ]; then 
                                [ -e ${name} ] && { 
# Needs to take ${line[n]} instead 
                                        [ "${tcheck}" ] && mtime=${line[3]} 
                                        [ "${tcheck}" ] && _mtime=`date -r ${na\ 
me} +%s` 
 
# Needs to take ${line[n-1]} instead 
                                        [ "${mcheck}" ] && md5=${line[2]} 
                                        [ "${mcheck}" ] && _md5=`md5sum ${name}\ 
|cut -f1 -d" "` 
                                } 
 
Comment 5 Brandon Low (RETIRED) gentoo-dev 2003-03-31 02:38:29 UTC
I'll take a look at this all ... maybe tomorrow, maybe not till next weekend... thanks for the hint.
Comment 6 leon j. breedt 2003-04-21 16:10:59 UTC
qpkg also can't handle spaces when it lists files. it truncates the displayed file name at the position of the first space.

i'll attach a diff that fixes this for the -l case.
Comment 7 leon j. breedt 2003-04-21 16:13:57 UTC
Created attachment 10960 [details, diff]
fixes spaces in filenames for qpkg -l
Comment 8 Bob Koutsky 2003-04-24 07:08:23 UTC
Another problem, probably closely related to handling spaces is handling of wildcard characters in filenames. For example, dev-util/guile-1.6.3 (not yet in portage tree, so far only in bugzilla) contains file "/usr/share/guile/1.6/ice-9/and-let*.scm", which seem to confuse qpkg.
Attached is a simple fix to it, not sure if it is complete.
Comment 9 Bob Koutsky 2003-04-24 07:16:01 UTC
Created attachment 11065 [details, diff]
Fixes handling of wildcard in filenames in qpkg -c -v
Comment 10 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2003-07-04 06:38:31 UTC
I'll take on this again. Summer cleanup in Gentoolkit
Comment 11 Charles Goodwin 2003-12-14 16:19:02 UTC
Is this fixed yet?  If not, please reopen.
Comment 12 Ole Tange 2003-12-15 00:12:15 UTC
I did:
emerge sync
emerge gentoolkit
emerge lcms
qpkg -c -v lcms

and I still get:

media-libs/lcms-1.11 *
/usr/share/lcms/profiles/sRGB !not exist!
1/33
Comment 13 Marius Mauch (RETIRED) gentoo-dev 2004-03-31 23:46:56 UTC
pre8 is in CVS now