Summary: | <app-i18n/librime-1.5.3-r1: librime writes sensitive information to world readable /tmp/${application_name}.INFO (e.g. /tmp/rime.fcitx-rime.INFO or /tmp/ibus.INFO) | ||
---|---|---|---|
Product: | Gentoo Security | Reporter: | OwenJia <aptx945> |
Component: | Vulnerabilities | Assignee: | Gentoo Security <security> |
Status: | RESOLVED FIXED | ||
Severity: | trivial | CC: | cjk, dlan |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | B4 [noglsa] | ||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 704258 | ||
Bug Blocks: |
Description
OwenJia
2019-09-27 02:28:13 UTC
the workaround only test on librime-1.4.0, cause 1.5.3 can not work, it's just crash. Problem is for upstream to solve. ENABLE_LOGGING=ON is default. ENABLE_LOGGING=ON enables dependency on Glog. Other distributions have LibRIME with dependency on Glog and no -DENABLE_LOGGING=OFF passed to cmake: Arch Linux: https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/librime Debian: https://salsa.debian.org/input-method-team/librime/blob/master/debian/control https://salsa.debian.org/input-method-team/librime/blob/master/debian/rules Fedora: https://apps.fedoraproject.org/packages/librime/sources/spec Glog provides possibility to configure various things, including log level, log directory and log file mode bits: https://github.com/google/glog/blob/master/doc/glog.html https://github.com/google/glog/blob/master/src/glog/logging.h.in https://github.com/google/glog/blob/4db06313464dadb5c5ca2619f3a461f0b61a07dc/src/glog/logging.h.in#L356-L365 https://github.com/google/glog/blob/master/src/logging.cc https://github.com/google/glog/blob/e5588de96d5305d5da00ad32bc31fda0864f3bfc/src/logging.cc#L134-L135 https://github.com/google/glog/blob/e5588de96d5305d5da00ad32bc31fda0864f3bfc/src/logging.cc#L149-L167 So LibRIME source code should set appropriate variable (at least FLAGS_logfile_mode=0600 to avoid security problem). In case of log directory, LibRIME could expose ability for its users (e.g. Fcitx-RIME, IBus-RIME) to set log directory. E.g. Fcitx scarcely uses ~/.config/fcitx/log directory, so this location could be set by Fcitx-RIME. Ideally logging level would be configurable in relevant GUI configuration editors of Fcitx-RIME and IBus-RIME... (In reply to OwenJia from comment #1) > 1.5.3 can not work, it's just crash. It was probably bug #692950. After updating dev-libs/darts and rebuilding app-i18n/librime-1.5.3, app-i18n/librime-1.5.3 is likely to work. https://github.com/rime/librime/issues/316 (Please test if my patch from this upstream bug works for you.) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d149e41c89b85dff47bd5cdc332e6c0817acdd72 commit d149e41c89b85dff47bd5cdc332e6c0817acdd72 Author: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> AuthorDate: 2019-12-23 21:18:36 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2019-12-29 19:31:34 +0000 app-i18n/librime: Set secure mode of log files. Bug: https://bugs.gentoo.org/695702 Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> Signed-off-by: Mike Gilbert <floppym@gentoo.org> app-i18n/librime/files/librime-1.5.3-log_files_mode.patch | 14 ++++++++++++++ .../{librime-1.5.3.ebuild => librime-1.5.3-r1.ebuild} | 6 +++++- 2 files changed, 19 insertions(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=313353afecffe37667c99824285f012d0b342676 commit 313353afecffe37667c99824285f012d0b342676 Author: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> AuthorDate: 2019-12-23 21:16:10 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2019-12-29 19:31:34 +0000 app-i18n/librime: Add "debug" USE flag. Bug: https://bugs.gentoo.org/695702 Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> Signed-off-by: Mike Gilbert <floppym@gentoo.org> app-i18n/librime/librime-1.5.3.ebuild | 8 +++++++- app-i18n/librime/metadata.xml | 3 +++ 2 files changed, 10 insertions(+), 1 deletion(-) Upstream recomments to have logging enabled (ENABLE_LOGGING=ON), but to disable debugging-level logging. Debugging-level logging is now controlled by "debug" USE flag, which is disabled by default. All logs are now created with 0600 mode for increased security. GLSA Vote: No Repository is clean, all done! |