Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 695014

Summary: app-office/lyx-2.3.4.2 version bump with support for Python 3
Product: Gentoo Linux Reporter: Arfrever Frehtes Taifersar Arahesis <arfrever.fta>
Component: Current packagesAssignee: Alexis Ballier <aballier>
Status: RESOLVED FIXED    
Severity: normal CC: anton.kochkov, atoth, cjk, dev, flexx, jstein, n.andrew.walsh, pacho, shinydoofy, ulm
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://github.com/gentoo/gentoo/pull/14784
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 694800, 721962    
Attachments: lyx-2.3.3.ebuild patch (see caveats in description)

Description Arfrever Frehtes Taifersar Arahesis 2019-09-20 01:49:15 UTC
app-office/lyx-2.3.* supposedly would mostly work with Python 3.
https://www.lyx.org/trac/ticket/9006

Some recently fixed problem:
https://www.lyx.org/trac/ticket/11642
https://www.lyx.org/trac/changeset/b9cc642856d79edb07cbd4067bbc10e5be9b2a36/lyxgit (master branch)
https://www.lyx.org/trac/changeset/d30da478d4f8ca861ee36ff77f6cc10c6f7bfd2b/lyxgit (2.3.x branch)
Comment 1 Laslo Hunhold 2019-12-13 07:42:16 UTC
Created attachment 599322 [details, diff]
lyx-2.3.3.ebuild patch (see caveats in description)

We can easily support Python 3.5, 3.6, 3.7 and 3.8 starting with version 2.3.4, which is further backed by the README[0] and one remark[1] by one of the developers.

The bug 11642 for version 2.3.3 only applied to macOS from what I could tell, but the important matter was b9cc642, which was applied _after_ the release of 2.3.3 and does not justify a general move to python3 for 2.3.3.

The bug fixed in b9cc642 is only triggered when there's no ~/.lyx directory present, so given I have it I added python3_{5,6,7,8} (as specified by upstream in the README), removed the patch applied to the ebuild in files/ and the PATCHES-variable and it worked just fine (tested with 3.5, 3.6, 3.7, 3.8 both exclusively as target and single-target), including reconfiguration (diff attached).

The only remaining question is when Lyx 2.3.4 will be released. The milestone[2] indicates that it won't be long.

[0]: https://www.lyx.org/trac/changeset/9234516731fac37651f5dacfc0942dc40775b96e/lyxgit/README
[1]: https://www.lyx.org/trac/ticket/11642#comment:19
[2]: https://www.lyx.org/trac/query?group=status&component=general&milestone=2.3.4
Comment 2 shinydoofy 2020-02-05 14:26:11 UTC
Lyx 2.3.4 has been released on 2020-01-31, see [1].

The patch from comment 1 does the trick for me: Lyx starts and looks to do just fine.

[1] https://www.lyx.org/News
Comment 3 Andrés Becerra Sandoval 2020-02-25 23:16:46 UTC
Now, there is a bug fix release LyX 2.3.4.2:

https://www.lyx.org/News#item1
Comment 4 Andrés Becerra Sandoval 2020-02-26 21:54:59 UTC
I opened PR:
https://github.com/gentoo/gentoo/pull/14784
Comment 5 Attila Tóth 2020-05-13 18:28:32 UTC
(In reply to Andrés Becerra Sandoval from comment #4)
> I opened PR:
> https://github.com/gentoo/gentoo/pull/14784

Ebuild 2.3.4.2 seems to be fine, however it is also affected by https://bugs.gentoo.org/721962
Comment 6 Andreas Sturmlechner gentoo-dev 2020-05-20 22:24:17 UTC
Dear maintainers, please help get that PR over the line.
Comment 7 Andreas Sturmlechner gentoo-dev 2020-05-20 22:24:39 UTC
*** Bug 722588 has been marked as a duplicate of this bug. ***
Comment 8 Andreas Sturmlechner gentoo-dev 2020-06-14 23:19:12 UTC
ping
Comment 9 Alexander Wessel 2020-06-19 20:48:14 UTC
(In reply to Attila Tóth from comment #5)
> (In reply to Andrés Becerra Sandoval from comment #4)
> > I opened PR:
> > https://github.com/gentoo/gentoo/pull/14784
> 
> Ebuild 2.3.4.2 seems to be fine, however it is also affected by
> https://bugs.gentoo.org/721962

lyx-2.3.5.1 was released with works with Python 3, and is no longer affected by bug 721962.
Comment 10 Larry the Git Cow gentoo-dev 2020-07-29 08:09:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a37759ff38b7eb98cd42eff6f99277464c32fa7e

commit a37759ff38b7eb98cd42eff6f99277464c32fa7e
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2020-07-29 08:05:25 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2020-07-29 08:08:44 +0000

    app-office/lyx: Version bump to 2.3.5.2, Python 3 support.
    
    Closes: https://bugs.gentoo.org/695014
    Closes: https://bugs.gentoo.org/721962
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-office/lyx/Manifest           |   1 +
 app-office/lyx/lyx-2.3.5.2.ebuild | 174 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 175 insertions(+)
Comment 11 Larry the Git Cow gentoo-dev 2020-10-23 12:06:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7aff113cf5d7acb3d79bf30d58c0b880c4b9039c

commit 7aff113cf5d7acb3d79bf30d58c0b880c4b9039c
Author:     Andrés Becerra <andres.becerra@gmail.com>
AuthorDate: 2020-02-26 21:44:14 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-10-23 12:04:09 +0000

    app-office/lyx: EAPI-7 bump, switch to app-text/enchant:2
    
    Signed-off-by: Andrés Becerra <andres.becerra@gmail.com>
    Tested-by: Andrés Becerra <andres.becerra@gmail.com>
    Bug: https://bugs.gentoo.org/695014
    Closes: https://github.com/gentoo/gentoo/pull/14784
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-office/lyx/lyx-2.3.5.2-r2.ebuild | 174 +++++++++++++++++++++++++++++++++++
 1 file changed, 174 insertions(+)