| Summary: | sci-mathematics/minisat-2.2.0_p20130925: header fix inserts incomplete path | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | phlo |
| Component: | Current packages | Assignee: | Gentoo Science Related Packages <sci> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | juippis |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=697562 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=494768fd4f91286c04abcac0cb06c6042720cd1f commit 494768fd4f91286c04abcac0cb06c6042720cd1f Author: Jeffrey Lin <jeffrey@icurse.nl> AuthorDate: 2019-01-04 03:37:59 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-10-21 14:32:09 +0000 sci-mathematics/minisat: fix sed in header files Bug: https://bugs.gentoo.org/697562 Closes: https://bugs.gentoo.org/694982 Package-Manager: Portage-2.3.53, Repoman-2.3.12 Signed-off-by: Jeffrey Lin <jeffrey@icurse.nl> Signed-off-by: Joonas Niilola <juippis@gentoo.org> ...minisat-2.2.0_p20130925.ebuild => minisat-2.2.0_p20130925-r1.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |
The ebuild contains an erroneous fix, changing the includes of internal library header files, which drops the specified standard system include subdirectory. The substitution in minisat-2.2.0_p20130925.ebuild:39 sed -i -e 's:#include "minisat/\([^"]*\)":#include <\1>:g' "${file}" || die should be changed to: sed -i -e 's:#include "minisat/\([^"]*\)":#include <minisat/\1>:g' "${file}" || die Reproducible: Always Steps to Reproduce: 1. write some code using libminisat, e.g.: #include <minisat/core/Solver.h> int main () { return 0; } 2. build Actual Results: Build fails due to Solver.h not being able to include any other library header: /usr/include/minisat/core/Solver.h:24:10: fatal error: mtl/Vec.h: No such file or directory #include <mtl/Vec.h> ^~~~~~~~~~~ compilation terminated. Expected Results: Build passes without an error.