Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 694120

Summary: app-antivirus/clamav-unofficial-sigs : install systemd timer and units
Product: Gentoo Linux Reporter: Alessandro Barbieri <lssndrbarbieri>
Component: Current packagesAssignee: Michael Orlitzky <mjo>
Status: RESOLVED TEST-REQUEST    
Severity: normal CC: gentoo
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=694054
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 448882    

Description Alessandro Barbieri 2019-09-12 03:06:48 UTC
upstream have a folder for those units
https://github.com/extremeshok/clamav-unofficial-sigs/tree/master/systemd
they only need to be installed
Comment 1 Michael Orlitzky gentoo-dev 2019-09-12 13:01:33 UTC
This looks simple enough. In light of bug 694054, I should probably provide a cron job, too.

I'm not sure if we can enable them by default, though. When the package is installed, you need to edit the configuration file and enable some databases and then set user_configuration_complete="yes" before anything will work.

Does anything bad happen if the cron job or systemd timer fires before the admin has time to edit the config file?
Comment 2 Larry the Git Cow gentoo-dev 2019-11-06 15:57:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3660c590ebed5b26bcb972d4feab4ecdb024aad1

commit 3660c590ebed5b26bcb972d4feab4ecdb024aad1
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2019-11-06 15:49:43 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2019-11-06 15:56:57 +0000

    app-antivirus/clamav-unofficial-sigs: new revision with systemd timer.
    
    For the same reason we introduced an /etc/cron.d job in the previous
    revision, it makes sense to include a systemd timer. The optimal
    settings for the update script are a bit tricky to get right, and
    since we run as the "clamav" user, they're both non-default and not
    entirely under our control.
    
    I haven't tested this (no systemd), but what could possibly go wrong?
    
    Bug: https://bugs.gentoo.org/694120
    Package-Manager: Portage-2.3.76, Repoman-2.3.16
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 ...1-r1.ebuild => clamav-unofficial-sigs-6.0.1-r2.ebuild} |  7 ++++++-
 .../files/clamav-unofficial-sigs.service                  | 15 +++++++++++++++
 .../files/clamav-unofficial-sigs.timer                    | 12 ++++++++++++
 3 files changed, 33 insertions(+), 1 deletion(-)
Comment 3 Michael Orlitzky gentoo-dev 2019-11-06 15:59:22 UTC
The most recent revision includes a service/timer that are disabled by default. Can you try to enable them and report back?