Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 694058

Summary: net-im/slack-bin : remove hardcoded Icon path in .desktop file
Product: Gentoo Linux Reporter: Simon <simon.vanderveldt+gentoo>
Component: Current packagesAssignee: Vladimir Pavljuchenkov (SpiderX) <spiderx>
Status: RESOLVED FIXED    
Severity: normal CC: proxy-maint
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Simon 2019-09-11 17:34:10 UTC
net-im/slack-bin's .desktop file has Icon set to a hardcoded path

> cat /usr/share/applications/slack.desktop | grep Icon
> Icon=/usr/share/pixmaps/slack.png

This means it's not possible to theme the icon using icon themes.
I'm using a local patch to change it to `Icon=slack` but it would be nice if this would work out of the box.

Would it be OK with including a patch for this?
Comment 1 Vladimir Pavljuchenkov (SpiderX) 2019-10-24 11:44:58 UTC
This was addressed in this commit https://github.com/gentoo/gentoo/commit/97abf8e1d28f88278ca051d53202dc84ca468748 or in ebuild 4.0.2.
Comment 2 Simon 2019-10-24 14:44:58 UTC
@Vladimir Pavljuchenkov (SpiderX)

Are you sure? I don't see a patch (or sed statement) for this in the 4.0.2 ebuild.
Comment 3 Vladimir Pavljuchenkov (SpiderX) 2019-10-24 15:00:27 UTC
4.0.2 wasn't added by me, that's why this is not in portage yet and exists only in my overlay.

Ok, it will be added in 4.1.1 then — https://github.com/gentoo/gentoo/pull/13410
Comment 4 Vladimir Pavljuchenkov (SpiderX) 2019-10-25 09:59:11 UTC
4.1.1 is in portage.