Bug 693498

Summary:	net-print/cups-filters-1.25.4 with app-text/qpdf-9.0.0 - filter/pdf.cxx:118:3: error: 'memcpy' was not declared in this scope
Product:	Gentoo Linux	Reporter:	jorgicio <jpizarrocallejas>
Component:	Current packages	Assignee:	Printing Team <printing>
Status:	RESOLVED FIXED
Severity:	normal	CC:	amanzharov, chris, email200202, klaus818, marduk, miyu.chs, phils, phobosk, remi, silvio.gerli, zeekec
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/OpenPrinting/cups-filters/issues/134 https://bugs.gentoo.org/show_bug.cgi?id=697078
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	The patch to fix

Description jorgicio 2019-09-04 16:03:29 UTC

Hi!

qpdf upgraded to 9.0.0, and it comes with some API changes. This breaks the re-build of cups-filters-1.25.4. Some reference can be found at: https://github.com/KaOSx/main/commit/e75230f91c03ad80c27f6781a1f35cd292d51577

Fortunately, I found a workaround to get rid of that and I'll upload the patch to fix that.

Thanks.

Reproducible: Always

Comment 1 jorgicio 2019-09-04 16:04:14 UTC

Created attachment 589042 [details, diff]
The patch to fix

Comment 2 Bernardo Meurer 2019-09-04 17:25:18 UTC

I have the same issue and can confirm that the patch solves it. Thanks jorgicio!

Comment 3 Bernardo Meurer 2019-09-04 17:34:38 UTC

Reported upstream: https://github.com/OpenPrinting/cups-filters/issues/151

Comment 4 Chris Faulkner 2019-09-04 18:03:32 UTC

Tried the patch, here's the error

 * Applying cups-filters-qpdf-9-fix.patch ...
The text leading up to this was:
--------------------------
|diff -Naur a/filter/pdf.cxx b/filter/pdf.cxx
|--- a/filter/pdf.cxx2019-09-04 11:57:33.104531512 -0400
|+++ b/filter/pdf.cxx2019-09-04 11:58:27.830347465 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

Comment 5 Chris Faulkner 2019-09-04 18:31:50 UTC

looks like the github version of cups-filters was changed to add the cstrings include

Comment 6 Silvio 2019-09-04 20:12:47 UTC

Same here

Comment 7 Silvio 2019-09-04 20:19:27 UTC

(In reply to Silvio from comment #6)
> Same here

Both problem and solution

Comment 8 Rémi Cardona (RETIRED) gentoo-dev

2019-09-05 06:26:46 UTC

Hey print team, mind if I commit this? Thanks

Comment 9 email200202 2019-09-05 06:40:54 UTC

Same here. The patch works.

Comment 10 Larry the Git Cow gentoo-dev

2019-09-05 06:45:24 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a65b125b85b64534a995da2e918073a15f404e38

commit a65b125b85b64534a995da2e918073a15f404e38
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-09-05 06:45:09 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-09-05 06:45:09 +0000

    net-print/cups-filters: Fixed build against app-text/qpdf-9.0.0
    
    Closes: https://bugs.gentoo.org/693498
    Package-Manager: Portage-2.3.75, Repoman-2.3.17
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 net-print/cups-filters/cups-filters-1.25.4.ebuild       |  4 ++++
 .../files/cups-filters-1.25.4-missing_cstring.patch     | 17 +++++++++++++++++
 2 files changed, 21 insertions(+)

Comment 11 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2019-09-05 13:03:44 UTC

*** Bug 693544 has been marked as a duplicate of this bug. ***

Comment 12 . 2019-10-04 16:39:19 UTC

you included the patch just in v1.25.x, all other branches are still affected, including "stable"