| Summary: | dev-util/cppcheck-2.2 bump request | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jens Lindenmeier <gentoo> |
| Component: | Current packages | Assignee: | Matthias Maier <tamiko> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ao, b.buschinski, dschridde+gentoobugs, gabemarcano, gentoo, jstein, O01eg, sping |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/danmar/cppcheck/releases | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
ebuild file that worked in my EPREFIX env...
2nd version of cppcheck-1.89.ebuild cppcheck-1.90.ebuild cppcheck-1.90-tinyxml2.patch cppcheck-2.2.ebuild |
||
I just realized that my ebuild is not yet working, will post a new ebuild as soon I find a solution. Created attachment 589010 [details]
2nd version of cppcheck-1.89.ebuild
Found a solution, ebuild attached.
tested in EPREFIX system only. Tested against ~100 cpp files including xml report generation. (cppcheck --xml)
Meanwhile, cppcheck-1.90 was released (2019-12-21). https://sourceforge.net/p/cppcheck/news/2019/12/cppcheck-190/ So, on cppcheck-1.90 they no longer use the CFGDIR variable, instead replacing it with FILESDIR... which collides with Gentoo's FILESDIR variable. Is there a better way to deal with the collision than sed s/FILESDIR/FILESDIR_/g on all the files in the project in src_prepare()? In any case, I spent some time trying to get something to work, and I think it kind of does? I'm uploading both a patch file and a prototype ebuild for 1.90. Created attachment 616182 [details]
cppcheck-1.90.ebuild
WIP cppcheck-1.90 ebuild.
Created attachment 616184 [details, diff]
cppcheck-1.90-tinyxml2.patch
Patch stripping tinyxml2 from the Makefile/dmake build system in cppcheck.
Matthias, any chance you could bump cppcheck to 2.0 this week? I need it to debug https://github.com/libexpat/libexpat/issues/404 and the live ebuild is failing to install. Thank you! Cppcheck 2.1 was released on 2020-06-13. https://sourceforge.net/p/cppcheck/news/2020/06/cppcheck-21/ cppcheck 2.2 was released on 2020-10-03. https://sourceforge.net/p/cppcheck/news/2020/10/cppcheck-22/ Created attachment 669587 [details]
cppcheck-2.2.ebuild
My initial try at cppcheck-2.2.ebuild
- cmake based
- uses internal tinyxml, it's a huge PITA to deal with it correctly
- more/different FILESDIR "fixes"
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f631b786b5dc48a16224e856417ceb44231428a7 commit f631b786b5dc48a16224e856417ceb44231428a7 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2020-12-04 04:56:31 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2020-12-04 05:37:16 +0000 dev-util/cppcheck: version bump to 2.2 Thanks to Bernd Buschinski for the initial ebuild Closes: https://bugs.gentoo.org/693352 Bug: https://bugs.gentoo.org/699594 Package-Manager: Portage-3.0.11, Repoman-3.0.2 Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-util/cppcheck/Manifest | 1 + dev-util/cppcheck/cppcheck-2.2.ebuild | 80 +++++++++++++++++++++++++++++++++++ dev-util/cppcheck/metadata.xml | 3 ++ profiles/arch/hppa/package.use.mask | 4 ++ profiles/arch/sparc/package.use.mask | 4 ++ 5 files changed, 92 insertions(+) |
Created attachment 588818 [details] ebuild file that worked in my EPREFIX env... cppcheck-1.89 has been released, this release was not straight forward, copy of ebuild of 1.88 was not possible. Attached an ebuild that worked for me, removing the patches from 1.88, removing the tinyxml dir deleting and modifying the install emake call, since cppcheck introduced FILESDIR Not sure if: CFGDIR="${EROOT}/usr/share/${PN}/cfg" \ DB2MAN="${EROOT}/usr/share/sgml/docbook/xsl-stylesheets/manpages/docbook.xsl" is still correct. I have an EPREFIX and for me also ROOT works, but better not change a running ebuild...