Bug 692030

Summary:	dev-vcs/git: Disable USE=python by default
Product:	Gentoo Linux	Reporter:	Matt Turner <mattst88>
Component:	Current packages	Assignee:	Robin Johnson <robbat2>
Status:	RESOLVED FIXED
Severity:	normal	CC:	polynomial-c
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	[PATCH] dev-vcs/git: Replace USE=+python with USE=perforce

Description Matt Turner gentoo-dev

2019-08-13 01:39:36 UTC

dev-vcs/git has IUSE=... +python ... and requires python2.7. I was curious to see what this actually offered since very few packages on my system require Python 2.

Unfortunately there's no metadata.xml entry for python, so it gets the default "Add optional support/bindings for the Python language" according to equery u.

Diffing two identical builds, one with USE=python and one with USE=-python, the only difference is: /usr/libexec/git-core/git-p4

git-p4 is 

   #!/bin/sh

   echo >&2 "fatal: git was built without support for $(basename $0) (NO_PYTHON=YesPlease)."
   exit 128

with USE=-python and an actual program with USE=python.

So the default IUSE=... +python ... is pulling in python:2.7 for a script to handle git/perforce integration.

That does not need to be on by default. Also, the USE flag needs to be renamed or at minimum described in metadata.xml.

Comment 1 Matt Turner gentoo-dev

2019-08-13 01:42:31 UTC

Created attachment 586698 [details, diff]
[PATCH] dev-vcs/git: Replace USE=+python with USE=perforce

Comment 2 Larry the Git Cow gentoo-dev

2019-08-16 22:58:22 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a83ca7c3fe8c4e0c700386a12066da5c2f8b4107

commit a83ca7c3fe8c4e0c700386a12066da5c2f8b4107
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2019-08-13 01:33:51 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2019-08-16 22:58:05 +0000

    dev-vcs/git: Replace USE=+python with USE=perforce
    
    Acked by Lars Wendler on IRC.
    
    Closes: https://bugs.gentoo.org/692030
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 dev-vcs/git/git-2.21.0-r2.ebuild  | 12 ++++++------
 dev-vcs/git/git-2.22.0.ebuild     | 12 ++++++------
 dev-vcs/git/git-2.22.1.ebuild     | 12 ++++++------
 dev-vcs/git/git-2.23.0_rc2.ebuild | 12 ++++++------
 dev-vcs/git/git-9999-r1.ebuild    | 12 ++++++------
 dev-vcs/git/git-9999-r2.ebuild    | 12 ++++++------
 dev-vcs/git/git-9999-r3.ebuild    | 12 ++++++------
 dev-vcs/git/git-9999.ebuild       | 10 +++++-----
 dev-vcs/git/metadata.xml          |  1 +
 9 files changed, 48 insertions(+), 47 deletions(-)