Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 691972

Summary: >=www-client/firefox-67[-system-av1] should depend on dev-lang/nasm only on amd64 / x86 architectures
Product: Gentoo Linux Reporter: Arfrever Frehtes Taifersar Arahesis <arfrever.fta>
Component: Current packagesAssignee: Mozilla Gentoo Team <mozilla>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=686440
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Patch for gentoo repository
Patch for mozilla repository

Description Arfrever Frehtes Taifersar Arahesis 2019-08-11 23:35:34 UTC 
In upstream build system:
https://hg.mozilla.org/mozilla-central/file/4e14ea350022024ec85cf3f79b843a933bbc65d2/toolkit/moz.configure#l458

def dav1d_asm(target, nasm_version):
    if target.os != 'Android':
        if target.cpu == 'aarch64':
            return True
        elif target.cpu in ('x86', 'x86_64'):
            if nasm_version < '2.13':
                die('nasm 2.13 or greater is required for AV1 support. '
                    'Either install nasm or add --disable-av1 to your configure options.')

            return True


This means that dependency on dev-lang/nasm is not needed on architectures other than amd64 and x86.
Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-08-11 23:38:47 UTC 
Created attachment 586604 [details, diff]
Patch for gentoo repository
Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-08-11 23:43:20 UTC 
For USE="system-av1", you can also see that media-libs/dav1d itself has this dependency conditional to amd64 / x86:
https://gitweb.gentoo.org/repo/gentoo.git/tree/media-libs/dav1d/dav1d-0.3.1.ebuild?id=e2e7fd45498368bcb40a9bdf51bf2a0994257356#n24

ASM_DEPEND=">=dev-lang/nasm-2.13"
RDEPEND=""
DEPEND="${RDEPEND}
	asm? (
		abi_x86_32? ( ${ASM_DEPEND} )
		abi_x86_64? ( ${ASM_DEPEND} )
	)"
Comment 3 Arfrever Frehtes Taifersar Arahesis 2019-08-11 23:49:44 UTC 
Created attachment 586606 [details, diff]
Patch for mozilla repository
Comment 4 Larry the Git Cow gentoo-dev 2019-08-12 16:10:48 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/mozilla.git/commit/?id=5643efb8974b1f19b52938686aae3daa7692f601

commit 5643efb8974b1f19b52938686aae3daa7692f601
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2019-08-11 23:35:56 +0000
Commit:     Jory Pratt <anarchy@gentoo.org>
CommitDate: 2019-08-12 16:10:28 +0000

    www-client/firefox: Depend on dev-lang/nasm only on amd64/x86.
    
    Fixes: https://bugs.gentoo.org/691972
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>

 www-client/firefox/firefox-68.0.1.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 5 Larry the Git Cow gentoo-dev 2019-08-12 16:12:20 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d16526cdd5821ae0647b50807a8da2b62dfa227

commit 7d16526cdd5821ae0647b50807a8da2b62dfa227
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2019-08-11 23:35:56 +0000
Commit:     Jory Pratt <anarchy@gentoo.org>
CommitDate: 2019-08-12 16:12:00 +0000

    www-client/firefox: Depend on dev-lang/nasm only on amd64/x86.
    
    Closes: https://bugs.gentoo.org/691972
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Jory Pratt <anarchy@gentoo.org>

 www-client/firefox/firefox-68.0.1.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)