| Summary: | media-tv/mythtv-29.1-r1 : imagemetadata.cpp:303:19: error: Error in namespace Exiv2 does not name a type | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | asturm, ilmostro7 |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 688566 | ||
| Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tbz2 logs.tbz2 media-tv:mythtv-29.1-r1:20190810-115020.log.bz2 mythtv-exiv2-fix |
||
Created attachment 586492 [details]
emerge-info.txt
Created attachment 586494 [details]
emerge-history.txt
Created attachment 586496 [details]
environment
Created attachment 586498 [details]
etc.portage.tbz2
Created attachment 586500 [details]
logs.tbz2
Created attachment 586502 [details]
media-tv:mythtv-29.1-r1:20190810-115020.log.bz2
Not a gcc issue. mythtv/libs/libmythmetadata/imagemetadata.cpp has this: // libexiv2 for Exif metadata //#include <exiv2/exiv2.hpp> // Note: Older versions of Exiv2 don't have the exiv2.hpp include // file. Using image.hpp instead seems to work. #ifdef _MSC_VER #include <exiv2/src/image.hpp> #else #include <exiv2/image.hpp> #endif Contrary to that comment, image.hpp does not work, and exiv2/exiv2.hpp should be used instead. Yeah, I'm not sure how far back one has to go for that comment to be true. It seems that exiv2/exiv2.hpp was included 9 years ago first. https://github.com/Exiv2/exiv2/blame/19e0693920b687ee789c37c4068e829e083d3838/include/exiv2/exiv2.hpp And can you confirm that uncommenting this header makes mythtv then build? Created attachment 586784 [details, diff]
mythtv-exiv2-fix
I can confirm that the proposal resolves build errors. I'm including the patch here; it can be added into a revbump commit for media-tv/mythtv.
$ grep -n PATCH media-tv/mythtv/mythtv-29.1-r2.ebuild
140:PATCHES="${FILESDIR}/${PN}-exiv2-fix"
I would need to clone the gentoo git tree in order to open a pull request. If that's necessary, I'll do so. However, if someone else is able to apply the patch into the tree, it's preferable.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c6efb1db19f9073bfd64c4a00e99fde85b05e9e0 commit c6efb1db19f9073bfd64c4a00e99fde85b05e9e0 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2019-08-14 11:12:05 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-08-14 11:14:42 +0000 media-tv/mythtv: Fix build with >=media-libs/exiv2-0.27.1 Thanks-to: Amel Hodzic <ilmostro7@gmail.com> Closes: https://bugs.gentoo.org/691904 Package-Manager: Portage-2.3.71, Repoman-2.3.17 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../mythtv/files/mythtv-29.1-exiv2-0.27.1.patch | 21 +++++++++++++++++++++ media-tv/mythtv/mythtv-29.1-r1.ebuild | 2 ++ 2 files changed, 23 insertions(+) |
imagemetadata.cpp: In constructor ‘PictureMetaData::PictureMetaData(const QString&)’: imagemetadata.cpp:303:19: error: ‘Error’ in namespace ‘Exiv2’ does not name a type 303 | catch (Exiv2::Error &e) | ^~~~~ In file included from imagemetadata.cpp:3: ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.1_desktop_plasma_systemd-abi32+64-20190807-151919 ------------------------------------------------------------------- Please see the tracker bug for details. gcc-config -l: [1] x86_64-pc-linux-gnu-9.1.0 * Available Python interpreters, in order of preference: [1] python3.6 [2] python2.7 (fallback) Available Ruby profiles: [1] ruby24 (with Rubygems) * Available Rust versions: [1] rust-1.36.0 * java-config: The following VMs are available for generation-2: 1) IcedTea JDK 3.13.0 [icedtea-8] *) IcedTea JDK 3.12.0 [icedtea-bin-8] Available Java Virtual Machines: [1] icedtea-8 [2] icedtea-bin-8 system-vm emerge -qpvO media-tv/mythtv [ebuild N ] media-tv/mythtv-29.1-r1 USE="alsa dvd hls python systemd theora vorbis wrapper xml xvid (-altivec) -autostart -bluray -cec -crystalhd -debug -dvb -egl -fftw -ieee1394 -jack -lcd -libass -lirc -mythlogserver -perl -pulseaudio -vaapi -vdpau -xmltv -zeroconf" INPUT_DEVICES="-joystick" PYTHON_TARGETS="python2_7"