Bug 691818

Summary:	app-editors/atom-1.32.1 with dev-libs/oniguruma-6.9.2 - "Uncaught Error: invalid code point value" opening PHP file
Product:	Gentoo Linux	Reporter:	Liam Dennehy <liam>
Component:	Current packages	Assignee:	Cynede (RETIRED) <cynede>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kripton
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Atom stack trace

Description Liam Dennehy 2019-08-09 11:45:11 UTC

Created attachment 586288 [details]
Atom stack trace

Related: https://github.com/elprans/atom-overlay/issues/41

Opening a PHP file in Atom editor 1.32.1 causes "Uncaught Error: invalid code point value", as illustrated in the attached stack trace, disabling PHP IDE features.

Masking =dev-libs/oniguruma-6.9.2 and downgrading to dev-libs/oniguruma-6.9.1 resolves the error.

Comment 1 PF4Public 2019-08-09 14:58:01 UTC

This is actually neither a bug in atom, nor in oniguruma. See this bug for more information: https://github.com/kkos/oniguruma/issues/146

Comment 2 Liam Dennehy 2019-08-09 15:22:12 UTC

Thanks for the quick analysis!

Right now the dependency is '>=dev-libs/oniguruma-6.6.0', perhaps extend this to '<=dev-libs/oniguruma-6.9.1' until the bug is resolved by either party?

Comment 3 Arfrever Frehtes Taifersar Arahesis 2019-08-15 00:29:12 UTC

Upstream said in https://github.com/kkos/oniguruma/issues/146#issuecomment-517928413:
"""
By the way, in the current master branch, I added ONIG_SYN_ALLOW_INVALID_CODE_END_OF_RANGE_IN_CC and enabled it in DEFAULT syntax only.
This allows invalid character code values at the end of a range in a character class.
"""

This change was released in dev-libs/oniguruma-6.9.3 which is already in the tree.

Does this change allow you to use app-editors/atom without problems?

Comment 4 Liam Dennehy 2019-08-15 07:45:40 UTC

Just completed a few tests (and did some learning on binary packages):

=dev-libs/oniguruma-6.9.1 -> PASS
=dev-libs/oniguruma-6.9.2 -> FAIL
=dev-libs/oniguruma-6.9.3 -> PASS

Looks good, thanks for the update!

Comment 5 Arfrever Frehtes Taifersar Arahesis 2019-08-15 08:35:37 UTC

dev-libs/oniguruma-6.9.3 is now stable due to security fixes (bug #691832).
I will delete older versions soon.
This bug can be closed.