Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 690568

Summary: x11-libs/libpciaccess-0.16 doesn't build if /bin/sh points to mksh
Product: Gentoo Linux Reporter: William <sirrobin2318>
Component: Current packagesAssignee: Gentoo X packagers <x11>
Status: RESOLVED FIXED    
Severity: normal CC: polynomial-c
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: libpciaccess.mksh.build
libpciaccess-0.16.ebuild.diff

Description William 2019-07-24 11:32:59 UTC
Created attachment 584288 [details]
libpciaccess.mksh.build

With sh set to mksh it doesn't build. No problem if set to bash.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-07-24 11:42:28 UTC
It builds fine with /bin/sh -> dash so I adjusted the Summary accordingly
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-07-24 12:05:11 UTC
Created attachment 584290 [details, diff]
libpciaccess-0.16.ebuild.diff

Possible fix...
Comment 3 Matt Turner gentoo-dev 2019-07-24 15:18:33 UTC
I wouldn't even both with the

+		# Don't use ${BASH} #690568

comment. But the change itself looks good. William, can you confirm that this fixes the problem?
Comment 4 Matt Turner gentoo-dev 2019-07-24 15:20:17 UTC
(In reply to Matt Turner from comment #3)
> I wouldn't even both with the

s/both/bother/ :)
Comment 5 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-07-26 08:57:49 UTC
(In reply to Matt Turner from comment #3)
> 
> William, can you confirm that this fixes the problem?


FYI, I could reproduce the issue and can confirm that my patch fixes it.
Comment 6 Larry the Git Cow gentoo-dev 2019-07-26 17:10:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e08a69a910587e5396e8358943733972d3ff720a

commit e08a69a910587e5396e8358943733972d3ff720a
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-07-26 17:08:31 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2019-07-26 17:08:58 +0000

    x11-libs/libpciaccess: Execute libtool with /bin/sh
    
    Closes: https://bugs.gentoo.org/690568
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 x11-libs/libpciaccess/libpciaccess-0.16.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)