Summary: | app-portage/cpuid2cpuflags should support cpu_flags_x86_sha for dev-libs/nettle | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Andrei Slavoiu <ansla80> |
Component: | Current packages | Assignee: | Michał Górny <mgorny> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alonbl, pacho, qa |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Andrei Slavoiu
2019-06-27 21:06:07 UTC
My first question would be, why was this added as a local flag in the first place? It obviously collides with global USE_EXPAND. And my answer would be not to block the bump until formalizing the new use flag name and the tuning of profiles. Once there will be a formal global flag and profiles proper masks, package will be modified. (In reply to Alon Bar-Lev from comment #2) > And my answer would be not to block the bump until formalizing the new use > flag name and the tuning of profiles. > > Once there will be a formal global flag and profiles proper masks, package > will be modified. So when are you planning to do this correctly and remove the band-aid? > So when are you planning to do this correctly and remove the band-aid?
I believe I replied per dev-libs/nettle:
I will be more than happy to:
1. remove the entire functionality now.
2. rename the USE flag until there will be a global flag.
3. remove the local USE description once there will be a global flag.
Pick the option you like, as I picked (3) as I believe it serves users the best until app-portage/cpuid2cpuflags is updated.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d0c54ca151d04776d24da5ca81be96155659ce36 commit d0c54ca151d04776d24da5ca81be96155659ce36 Author: Alon Bar-Lev <alonbl@gentoo.org> AuthorDate: 2019-07-08 13:24:03 +0000 Commit: Alon Bar-Lev <alonbl@gentoo.org> CommitDate: 2019-07-08 13:31:17 +0000 dev-libs/nettle: USE cpu_flags_x86_sha->preview-cpu_flags_x86_sha A temporary solution until cpu_flags_x86_sha available. Bug: https://bugs.gentoo.org/show_bug.cgi?id=688858 Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org> Package-Manager: Portage-2.3.66, Repoman-2.3.11 dev-libs/nettle/metadata.xml | 2 +- dev-libs/nettle/nettle-3.5.1.ebuild | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ebd359904856d99cbf2cbba6abc96ef183528e6f commit ebd359904856d99cbf2cbba6abc96ef183528e6f Author: Alon Bar-Lev <alonbl@gentoo.org> AuthorDate: 2019-07-08 13:38:49 +0000 Commit: Alon Bar-Lev <alonbl@gentoo.org> CommitDate: 2019-07-08 13:42:49 +0000 dev-libs/nettle: remove preview-cpu_flags_x86_sha Bug: https://bugs.gentoo.org/show_bug.cgi?id=688858 Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org> Package-Manager: Portage-2.3.66, Repoman-2.3.11 dev-libs/nettle/metadata.xml | 3 --- dev-libs/nettle/nettle-3.5.1.ebuild | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) Closing per commit https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b849cbe2f94883b679570753863ceebd364f2be7: commit b849cbe2f94883b679570753863ceebd364f2be7 Author: Michał Górny <mgorny@gentoo.org> Date: Thu Jul 18 16:54:24 2019 +0200 dev-libs/nettle: [QA] Revert cpu_flags_x86_sha removal Reverts: ebd359904856d99cbf2cbba6abc96ef183528e6f Reverts: d0c54ca151d04776d24da5ca81be96155659ce36 Signed-off-by: Michał Górny <mgorny@gentoo.org> |