Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 688626

Summary: =dev-games/openscenegraph-3.6.5-r1 links against bundled Lua
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Maciej Mrozowski <reavertm>
Status: RESOLVED FIXED    
Severity: QA CC: esigra, games
Priority: Lowest    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 773310    
Bug Blocks: 251464    
Attachments: dev-games:openscenegraph-3.5.5:20190624-023751.log.bz2
etc.portage.tbz2

Description Toralf Förster gentoo-dev 2019-06-24 18:26:58 UTC 
QA: other
One or more CMake variables were not used by the project:
  GENTOO_DOCDIR
  WITH_Lua
  WITH_Lua51

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1-desktop-plasma-systemd_20190619-191525

  -------------------------------------------------------------------
Comment 1 Toralf Förster gentoo-dev 2019-06-24 18:27:01 UTC 
Created attachment 580640 [details]
dev-games:openscenegraph-3.5.5:20190624-023751.log.bz2
Comment 2 Toralf Förster gentoo-dev 2019-06-24 18:27:04 UTC 
Created attachment 580642 [details]
etc.portage.tbz2
Comment 3 Maciej Mrozowski gentoo-dev 2020-10-06 20:00:00 UTC 
Update for osg-3.6.5

    CMAKE_DISABLE_FIND_PACKAGE_Lua51
    CMAKE_DISABLE_FIND_PACKAGE_Lua52

Harmless, buildsystem has two find_package() directives but second is behind conditional so will not always produce CMake option. And ebuild just relies on both present. Not really worth "fixing".
Comment 4 Marek Szuba archtester gentoo-dev 2020-12-21 23:14:03 UTC 
Unfortunately in case of 3.6.5-r1 there is another problem here manifesting in the same fashion - the two Lua-related find_package calls these variables attempt to override are only invoked if ${OSG_USE_LOCAL_LUA_SOURCE} evaluates to false, and this ebuild leaves said variable at its default value of ON. This means that the OpenSceneGraph Lua plug-in is a) linked against bundled liblua, and b) built regardless of whether USE=lua has been set or not

Among the dev-games/openscenegraph ebuilds currently in the tree only 3.6.5-r1 exhibits this problem, as both 3.6.4 and 3.6.5-r100 do set -DOSG_USE_LOCAL_LUA_SOURCE=OFF in src_configure.
Comment 5 Maciej Mrozowski gentoo-dev 2021-02-27 17:23:40 UTC 
Let's stabilize -r100 then and drop the rest. Why did you call it -r100, -r2 was not good enough? ;)
Comment 6 Maciej Mrozowski gentoo-dev 2021-02-27 17:34:30 UTC 
I created https://bugs.gentoo.org/773310