Bug 688278 – repoman wrongly complains about 'Gentoo Foundation' copyright in old ebuilds

• Product: Portage Development
• Status: RESOLVED FIXED

[Description Michał Górny 2019-06-18 07:06:03 UTC]

Example:

  ebuild.badheader              2
   dev-python/sure/sure-1.2.3.ebuild: Invalid Copyright on line: 1
   dev-python/sure/sure-1.2.5.ebuild: Invalid Copyright on line: 1

$ head -1 sure-1.2.[35].ebuild
==> sure-1.2.3.ebuild <==
# Copyright 1999-2015 Gentoo Foundation

==> sure-1.2.5.ebuild <==
# Copyright 1999-2015 Gentoo Foundation

Both ebuilds were obviously unchanged since 2015, and I'm pretty sure the policy so far was not to change copyright headers unless you were changing the ebuild as well.  This is apparently a regression caused by:

commit 1f2d1e63a605d5ad4a9257e0102b9803bc59aeb6
Author: Ulrich Müller <[e-mail]>
Date:   Mon Jun 3 17:02:02 2019

    repoman: Update header check for Gentoo repo policy.
    
    By decision of the Gentoo Council in its 2019-01-13 meeting, ebuilds
    in the Gentoo repository MUST use the simplified form of the copyright
    attribution according to GLEP 76, i.e.: "Copyright YEARS Gentoo Authors".
    
    Update the header check accordingly, mostly by reverting to the
    simpler single line check that was in place before commit c4096aff48.
    
    Bug: https://bugs.gentoo.org/666330
    Signed-off-by: Ulrich Müller <[e-mail]>
    Signed-off-by: Zac Medico <[e-mail]>

[Comment 1 Ulrich Müller 2019-06-18 08:02:11 UTC]

(In reply to Michał Górny from comment #0)
> I'm pretty sure the policy so far was not to change copyright headers
> unless you were changing the ebuild as well.

I don't think that we have defined any such policy. Please provide a reference.

"Gentoo Foundation" agrees neither with GLEP 76 nor with tree policy (quoted in the first paragraph of the commit message), so repoman should display a warning.

In any case, repoman will only update the header if the ebuild has changed.

[Comment 2 Ulrich Müller 2019-06-18 08:09:43 UTC]

(In reply to Ulrich Müller from comment #1)
> "Gentoo Foundation" agrees neither with GLEP 76 nor with tree policy (quoted
> in the first paragraph of the commit message), so repoman should display a
> warning.

Correction: Theoretically, "Copyright YEARS Gentoo Foundation" could be a valid attribution by GLEP 76, if all authors of the file had previously assigned copyright to Gentoo Technologies Inc., and if subsequently the ebuild hasn't had any copyrightable changes after 2005. However, I believe that finding even a single such example would be hard. Also, it would still not comply with tree policy.

[Comment 3 Michał Górny 2019-06-18 08:18:19 UTC]

If you believe old ebuilds should be updated, then let's mass-update them instead of having people bothered by repoman warnings for ancient ebuilds.

[Comment 4 Ulrich Müller 2019-06-18 08:34:17 UTC]

(In reply to Michał Górny from comment #3)
> If you believe old ebuilds should be updated, then let's mass-update them
> instead of having people bothered by repoman warnings for ancient ebuilds.

This was discussed in the 20190113 Council meeting, and (tacid) consensus was that we won't do a change in bulk, but update ebuilds as we go along.

[Comment 5 Michał Górny 2019-06-18 08:42:39 UTC]

Then repoman shouldn't bother people if there is no other change pending.

[Comment 6 Ulrich Müller 2019-06-18 11:52:34 UTC]

Created attachment 580074 [details, diff]
repoman: Allow legacy "Gentoo Foundation" copyright before 2019.

As discussed in #gentoo-portage.

[Comment 7 Ulrich Müller 2019-06-18 12:47:15 UTC]

Created attachment 580076 [details, diff]
repoman: Allow legacy "Gentoo Foundation" copyright before 2019.

Small update, with fixed grouping inside the if statement.

[Comment 8 Larry the Git Cow 2019-06-18 18:51:20 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=31465138ddc319a98eae71f95b9fb3a07b866f62

commit 31465138ddc319a98eae71f95b9fb3a07b866f62
Author:     Ulrich Müller <[e-mail]>
AuthorDate: 2019-06-18 11:48:33 +0000
Commit:     Zac Medico <[e-mail]>
CommitDate: 2019-06-18 18:41:31 +0000

    repoman: Allow legacy "Gentoo Foundation" copyright before 2019.
    
    Bug: https://bugs.gentoo.org/688278
    Signed-off-by: Ulrich Müller <[e-mail]>
    Signed-off-by: Zac Medico <[e-mail]>

 repoman/lib/repoman/modules/linechecks/gentoo_header/header.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

[Comment 9 Larry the Git Cow 2019-06-20 01:21:03 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6a639af12aa9535a903e7a13a88a71e3cd0acd1d

commit 6a639af12aa9535a903e7a13a88a71e3cd0acd1d
Author:     Zac Medico <[e-mail]>
AuthorDate: 2019-06-20 01:17:24 +0000
Commit:     Zac Medico <[e-mail]>
CommitDate: 2019-06-20 01:18:44 +0000

    app-portage/repoman: Bump to version 2.3.15
    
     #688278 Accept 'Gentoo Foundation' copyright for old ebuilds
    
    Closes: https://bugs.gentoo.org/688278
    Package-Manager: Portage-2.3.67, Repoman-2.3.15
    Signed-off-by: Zac Medico <[e-mail]>

 app-portage/repoman/Manifest              |  1 +
 app-portage/repoman/repoman-2.3.15.ebuild | 63 +++++++++++++++++++++++++++++++
 2 files changed, 64 insertions(+)