Summary: | New Ebuild for ss5-2.4 socks 5 server | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Andreas Kobara <abusch> |
Component: | New packages | Assignee: | Gentoo Dialup Developers <net-dialup> |
Status: | RESOLVED INVALID | ||
Severity: | enhancement | Keywords: | EBUILD |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://digilander.libero.it/matteo.ricchetti/ss5_linux.html | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ss5-2.4.ebuild
ss5-2.4-gentoo-init-script |
Description
Andreas Kobara
2004-10-25 06:55:02 UTC
Created attachment 42558 [details]
ss5-2.4.ebuild
Created attachment 42559 [details]
ss5-2.4-gentoo-init-script
Isn't it more apropriate to put it in net-misc than net-dialup? After all, in net-misc we have net-misc/sock and net-misc/tsocks There are following problems: - indentation of the ebuild is a mess. please put tabs for indent lines. - remove slb flag. you should enable support for load balancing without this. - RDEPEND should not be set at all. Default it is equal with DEPEND and in this case is the right thing. - a CFLAGS += ... is preferred - you should use "s:^LIBS *=.*:&${mylibs}:". it increase ebuild maintainability - pkg_postinst is a little too much. there is no essential information in it. better get rid of it. - reload of service is a little too prolix. you should tell the user only that config file is automatically reloaded after 30 secs, not give him that hint with killall - reload should not call killall. better you save pid in a file (see start-stop-daemon help for that) and send signal only to that pid. please solve this issues, test the result and repost the ebuild. thank you. I guess you aren't interested anymore. |