Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 688124

Summary: emerge does not show correct download size for partially downloaded files
Product: Portage Development Reporter: Cihan Özakça <cozakca>
Component: CoreAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: minor Keywords: InVCS, REGRESSION
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
URL: https://github.com/gentoo/portage/pull/433
See Also: https://bugs.gentoo.org/show_bug.cgi?id=175612
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 686768    
Attachments: emerge info

Description Cihan Özakça 2019-06-15 19:50:40 UTC
Created attachment 579876 [details]
emerge info

Sorry about bad english.

Emerge doesnt see partially downloaded source present in harddisk and shows the full package size as needs to be downloaded. with the older portage it was showing remaning download size.
Comment 1 Zac Medico gentoo-dev 2019-06-16 20:54:10 UTC
The portdbapi.getfetchsizes method needs to be adjusted to account for files with the .__download__ suffix since the fix for bug 175612:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=ebbde237d33e783c562cc6c70987969ac7228b96
Comment 2 Larry the Git Cow gentoo-dev 2019-06-20 19:43:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=611a53a6943bf25ac8c1d909e34e4b37c8873e83

commit 611a53a6943bf25ac8c1d909e34e4b37c8873e83
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2019-06-20 01:37:53 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-06-20 02:21:36 +0000

    portdbapi.getfetchsizes: use .__download__ suffix
    
    If the file does not exist locally or the size is not correct,
    use the file with the .__download__ suffix to compute the
    remaining_size to fetch.
    
    Fixes: ebbde237d33e ("fetch: atomic downloads (bug 175612)")
    Bug: https://bugs.gentoo.org/688124
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/portage/dbapi/porttree.py | 12 ++++++++++++
 1 file changed, 12 insertions(+)