Bug 688070

Summary:	=dev-lua/toluapp-1.0.93_p20190513 doesn't install required files
Product:	Gentoo Linux	Reporter:	Victor Mataré <vmatare+gbug>
Component:	Current packages	Assignee:	Gentoo Linux bug wranglers <bug-wranglers>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	fixed cmake patch

Description Victor Mataré 2019-06-14 16:08:56 UTC

When I try to run it:

$ strace -f tolua++  SkillerDebugInterface_tolua.pkg
[...]
openat(AT_FDCWD, "/usr/share/toluapp/luapp/all.lua", O_RDONLY) = -1 ENOENT (No such file or directory)
write(2, "luaL_loadfile failed\n", 21luaL_loadfile failed
)  = 21
[...]

In fact, /usr/share/toluapp doesn't even exist. Package contents:

$ qlist toluapp
/usr/bin/tolua++
/usr/lib64/libtolua++.so
/usr/include/tolua++.h
/usr/share/doc/toluapp-1.0.93_p20190513/README-5.1.bz2
/usr/share/doc/toluapp-1.0.93_p20190513/html/toluapp.gif
/usr/share/doc/toluapp-1.0.93_p20190513/html/tolua++.html
/usr/share/doc/toluapp-1.0.93_p20190513/html/index.html
/usr/share/doc/toluapp-1.0.93_p20190513/README.bz2

Comment 1 Victor Mataré 2019-06-14 17:03:06 UTC

Created attachment 579778 [details, diff]
fixed cmake patch

install lua files where they belong

Comment 2 Victor Mataré 2019-06-14 17:05:33 UTC

There's actually two problems. First, cmake doesn't install any of the lua code. That can be fixed easily in the patch that is already being applied.

Second, the ebuild patches tolua++ to be incompatible with <lua-5.3, but specifies >=lua-5.1 as dependency. That could be fixed by splitting it in two ebuilds, one that patches for lua-5.3 and one that doesn't. With the appropriate dependencies, of course.

Comment 3 Larry the Git Cow gentoo-dev

2019-06-16 15:01:21 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=795a587235c11f13c183e2ee4277322f3ac8e8af

commit 795a587235c11f13c183e2ee4277322f3ac8e8af
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2019-06-16 15:00:52 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2019-06-16 15:00:52 +0000

    dev-lua/toluapp: Fix packaging and drop lua 5.3 patches
    
    Closes: https://bugs.gentoo.org/688070
    Package-Manager: Portage-2.3.67, Repoman-2.3.14
    Signed-off-by: David Seifert <soap@gentoo.org>

 .../toluapp-1.0.93_p20190513-fix-multilib.patch    |   3 +-
 .../files/toluapp-1.0.93_p20190513-lua5.3.patch    | 534 ---------------------
 ...3.ebuild => toluapp-1.0.93_p20190513-r1.ebuild} |   3 +-
 3 files changed, 3 insertions(+), 537 deletions(-)