Bug 687988

Summary:	app-portage/eix: linker error on Cygwin due to -mindirect-branch=thunk
Product:	Gentoo Linux	Reporter:	Michael Haubenwallner (RETIRED) <haubi>
Component:	Current packages	Assignee:	Mikle Kolyada (RETIRED) <zlogene>
Status:	RESOLVED FIXED
Severity:	normal	CC:	martin, mgorny
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Other
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	proposed ebuild patch proposed ebuild patch, r1

Description Michael Haubenwallner (RETIRED) gentoo-dev

2019-06-13 09:24:41 UTC

In Prefix on Cygwin (~x64-cygwin), because of the -mindirect-branch=thunk compiler flag, linking eix.exe fails with lots of these:
 relocation truncated to fit: R_X86_64_32S against `.text'

Reported upstream as https://github.com/vaeth/eix/issues/64

In lack of a real fix, this bug is about the downstream workaround to disable -mindirect-branch=thunk for Cygwin.

Comment 1 Michael Haubenwallner (RETIRED) gentoo-dev

2019-06-13 09:28:14 UTC

Created attachment 579696 [details, diff]
proposed ebuild patch

Ok to push?

Comment 2 Michał Górny archtester

2019-06-13 09:32:48 UTC

Can't you disable them via autoconf cache variables?  Seds on configure are awfully ugly.

Comment 3 Michael Haubenwallner (RETIRED) gentoo-dev

2019-06-13 10:23:55 UTC

I fail to find MV_ADDFLAGS defining a cache variable per checked flag.

Comment 4 Michał Górny archtester

2019-06-13 11:05:28 UTC

I think setting mv_fCXXFLAGS_cache should work here.

Comment 5 Michael Haubenwallner (RETIRED) gentoo-dev

2019-06-24 16:28:01 UTC

Created attachment 580636 [details, diff]
proposed ebuild patch, r1

Indeed... interesting use of a cache variable.

Patch updated, for 0.33.8 now.

Given that upstream removed the flag completely, should we drop the cygwin conditional here as well?

Comment 6 Michał Górny archtester

2019-07-28 06:08:37 UTC

(In reply to Michael Haubenwallner from comment #5)
> Created attachment 580636 [details, diff] [details, diff]
> proposed ebuild patch, r1
> 
> Indeed... interesting use of a cache variable.
> 
> Patch updated, for 0.33.8 now.
> 
> Given that upstream removed the flag completely, should we drop the cygwin
> conditional here as well?

That sounds fine.  I'll do that for ya and merge it.

Comment 7 Larry the Git Cow gentoo-dev

2019-07-28 06:41:21 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9cba1867a54e16cf8657b32d184cf436432a6dd5

commit 9cba1867a54e16cf8657b32d184cf436432a6dd5
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-07-28 06:09:57 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-07-28 06:41:07 +0000

    app-portage/eix: Fix Cygwin linking issues
    
    Closes: https://bugs.gentoo.org/687988
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 app-portage/eix/eix-0.33.8.ebuild | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=425757f0274a39eb0392196fb45efc8d9f3eb3f4

commit 425757f0274a39eb0392196fb45efc8d9f3eb3f4
Author:     Michael Haubenwallner <haubi@gentoo.org>
AuthorDate: 2019-06-13 09:26:39 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-07-28 06:41:06 +0000

    app-portage/eix: work around cygwin linker issue
    
    Upstream report: https://github.com/vaeth/eix/issues/64
    
    Closes: https://bugs.gentoo.org/687988
    Package-Manager: Portage-2.3.66, Repoman-2.3.11
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 app-portage/eix/eix-0.33.8.ebuild | 5 +++++
 1 file changed, 5 insertions(+)