Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 687890

Summary: dev-perl/MP3-Tag-1.150.0 stabilization
Product: Gentoo Linux Reporter: Phil Stracchino (Unix Ronin) <phils>
Component: StabilizationAssignee: Gentoo Perl team <perl>
Status: RESOLVED FIXED    
Severity: normal CC: jstein, phils, sound
Priority: Normal Keywords: STABLEREQ
Version: unspecifiedFlags: stable-bot: sanity-check+
Hardware: All   
OS: Linux   
Whiteboard: was: dev-perl/MP3-Tag-1.150.0 version bump (fixes: Unescaped left brace in regex)
Package list:
dev-perl/MP3-Tag-1.150.0
Runtime testing required: ---
Attachments:
Description Flags
Patch for unescaled left braces in MP3/Tag.pm none

Description Phil Stracchino (Unix Ronin) 2019-06-11 20:28:50 UTC
Created attachment 579578 [details, diff]
Patch for unescaled left braces in MP3/Tag.pm

Use of MP3::Tag in dev-lang/perl-5.28.2-r1 yields the following warning in two different places:

Unescaped left brace in regex is deprecated here (and will be fatal in Perl
        5.32), passed through in regex; marked by <-- HERE in m/^({ <-- HERE [^{}]+}|\w)/ at /usr/lib64/perl5/vendor_perl/5.28.2/MP3/Tag.pm line 3092 (#1)


Fix:
See attached diff.
Comment 1 Jonas Stein gentoo-dev 2019-06-12 16:36:40 UTC
Thank you for the patch.
Please check also if it is fixed upstream in the latest version. If not, please report and link the report here.
https://metacpan.org/release/MP3-Tag
Comment 2 Phil Stracchino (Unix Ronin) 2019-06-12 17:08:34 UTC
(In reply to Jonas Stein from comment #1)
> Thank you for the patch.
> Please check also if it is fixed upstream in the latest version. If not,
> please report and link the report here.
> https://metacpan.org/release/MP3-Tag

I just checked, and it looks as though current upstream is already fixed.
Comment 3 Larry the Git Cow gentoo-dev 2019-07-16 02:08:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=797eaad956caf6115032eac0fd8808fa3eb0d2b7

commit 797eaad956caf6115032eac0fd8808fa3eb0d2b7
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2019-07-16 02:07:52 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2019-07-16 02:08:13 +0000

    dev-perl/MP3-Tag: Bump to version 1.150.0 re bug #687890
    
    Upstream:
    - Fix more warnings about use of deprecated unescaped left brace
    
    Bug: https://bugs.gentoo.org/687890
    Package-Manager: Portage-2.3.66, Repoman-2.3.16
    Signed-off-by: Kent Fredric <kentnl@gentoo.org>

 dev-perl/MP3-Tag/MP3-Tag-1.150.0.ebuild | 23 +++++++++++++++++++++++
 dev-perl/MP3-Tag/Manifest               |  1 +
 2 files changed, 24 insertions(+)
Comment 4 Andreas K. Hüttel archtester gentoo-dev 2019-10-15 12:08:40 UTC
Please stabilize dev-perl/MP3-Tag-1.150.0
Comment 5 Agostino Sarubbo gentoo-dev 2019-10-17 10:25:49 UTC
ppc stable
Comment 6 Agostino Sarubbo gentoo-dev 2019-10-17 10:30:04 UTC
ppc64 stable
Comment 7 Agostino Sarubbo gentoo-dev 2019-10-17 10:33:03 UTC
x86 stable
Comment 8 Agostino Sarubbo gentoo-dev 2019-10-17 11:23:57 UTC
amd64 stable. Closing.