Bug 687838

Summary:	net-wireless/wpa_supplicant-2.8 : USE="-ap", USE="-smartcard", etc., don't do anything
Product:	Gentoo Linux	Reporter:	Brian Norris <computersforpeace>
Component:	Current packages	Assignee:	Rick Farina (Zero_Chaos) <zerochaos>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/12237 https://github.com/gentoo/gentoo/pull/13146
Whiteboard:
Package list:		Runtime testing required:	---

Description Brian Norris 2019-06-11 00:20:53 UTC

Similar to this bug:

https://bugs.gentoo.org/684284

except that this doesn't result in a functional (build) failure -- it just builds in unwanted features.

CONFIG_AP
CONFIG_WPS
CONFIG_SMARTCARD

are all part of the defconfig. So we need to explicitly disable them if we want to pretend the USE flags do anything.

Will upload a PR on github.

Reproducible: Always

Comment 1 Brian Norris 2019-06-11 00:23:10 UTC

https://github.com/gentoo/gentoo/pull/12237

Comment 2 Brian Norris 2019-06-11 00:33:55 UTC

TDLS (not enabled by default) could be in the same boat someday. I think EAP_FAST (USE=fasteap), P2P (USE=p2p), and probably more currently have this problem.

Comment 3 Larry the Git Cow gentoo-dev

2019-06-11 01:18:29 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b6759c261091a763379979a40fc9cedae86bf92

commit 5b6759c261091a763379979a40fc9cedae86bf92
Author:     Brian Norris <briannorris@chromium.org>
AuthorDate: 2019-06-11 00:18:40 +0000
Commit:     Rick Farina <zerochaos@gentoo.org>
CommitDate: 2019-06-11 01:18:14 +0000

    net-wireless/wpa_supplicant: support USE="-smartcard -ap -wps"
    
    These are enabled in the defconfig and need to be forced off here.
    
    Bug: https://bugs.gentoo.org/687838
    Signed-off-by: Brian Norris <briannorris@chromium.org>
    Signed-off-by: Rick Farina <zerochaos@gentoo.org>

 net-wireless/wpa_supplicant/wpa_supplicant-2.8-r1.ebuild | 6 ++++++
 1 file changed, 6 insertions(+)

Comment 4 Don O 2019-10-04 20:30:08 UTC

as per comment #2
P2P (USE=p2p) is a problem, it's turned on, whether the use flag is set or not.

It is creating a problem with wpa_cli (unless the -i interface flag is used) as p2p-dev-<dev name> is selected as default device.

Comment 5 Brian Norris 2019-10-04 22:23:38 UTC

@Don O: Good point. I probably should have just submitted a PR for that too when we noticed it:

https://bugs.chromium.org/p/chromium/issues/detail?id=958889

We already have this fixed in Chromium OS:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1593931/
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ffd92a942b9fd976f47f42b736434c6ab88581b3

New PR here: https://github.com/gentoo/gentoo/pull/13146

Comment 6 Rick Farina (Zero_Chaos) gentoo-dev

2020-02-13 18:16:40 UTC

I'm pulling this into 2.9-r2. thanks!