Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 687820

Summary: sys-boot/vboot-utils-72_p20181229 - armv7a-unknown-linux-musleabihf-ld: [...]/work/build/futility/updater_archive.o: in function `archive_fallback_walk' : updater_archive.c:(.text+0x550): undefined reference to `fts_open'
Product: Gentoo Linux Reporter: Alpha Bravo <aos>
Component: Current packagesAssignee: Gentoo musl team <musl>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build.log
emerge --info
Add proper sys-libs/fts-standalone dep for musl

Description Alpha Bravo 2019-06-10 19:25:22 UTC
After working around https://bugs.gentoo.org/678594 and https://bugs.gentoo.org/687008 (on armv7a-unknown-linux-musleabihf), with sys-libs/fts-standalone present, compilation of vboot-utils-72_p20181229 fails
 with "[...]/work/build/futility/updater_archive.o: in function `archive_fallback_walk' : updater_archive.c:(.text+0x550): undefined reference to `fts_open'"

Reproducible: Always




If sys-libs/fts-standalone is not present compilation of vboot-utils fails with "futility/updater_archive.c:11:10: fatal error: fts.h: No such file or directory"

Currently fts-standalone is pulled in via vboot-utils' dependency on dev-libs/libzip

Maybe vboot-utils should depend on fts-standalone on musl
Comment 1 Alpha Bravo 2019-06-10 19:35:47 UTC
Created attachment 579508 [details]
build.log
Comment 2 Alpha Bravo 2019-06-10 19:37:41 UTC
Created attachment 579510 [details]
emerge --info
Comment 3 Jory A. Pratt gentoo-dev 2019-06-13 00:37:18 UTC
Created attachment 579686 [details, diff]
Add proper sys-libs/fts-standalone dep for musl

Waiting for permission from maintainer to push to tree
Comment 4 Larry the Git Cow gentoo-dev 2019-06-13 01:52:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c24cbd37c6d967028dcb5ed93568b6da56eecda0

commit c24cbd37c6d967028dcb5ed93568b6da56eecda0
Author:     Jory Pratt <anarchy@gentoo.org>
AuthorDate: 2019-06-13 01:52:17 +0000
Commit:     Jory Pratt <anarchy@gentoo.org>
CommitDate: 2019-06-13 01:52:40 +0000

    sys-boot/vboot-utils: fix libressl support, musl dep fix
    
    Closes: https://bugs.gentoo.org/678594
    Closes: https://bugs.gentoo.org/687820
    Package-Manager: Portage-2.3.67, Repoman-2.3.14
    Signed-off-by: Jory Pratt <anarchy@gentoo.org>

 .../vboot-utils/files/vboot-utils-72_p20181229-libressl.patch | 11 +++++++++++
 ...72_p20181229.ebuild => vboot-utils-72_p20181229-r1.ebuild} |  2 ++
 2 files changed, 13 insertions(+)
Comment 5 Alpha Bravo 2019-06-14 10:32:43 UTC
The commit message claims a "musl dep fix" but the commit only deals with the libressl issue from bug #678594

In any case the issue with fts is not resolved, nothing changed.
Comment 6 Larry the Git Cow gentoo-dev 2019-06-14 13:25:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b9bd152cb35ea77eab781f9ac5fae95ffa343ba0

commit b9bd152cb35ea77eab781f9ac5fae95ffa343ba0
Author:     Jory Pratt <anarchy@gentoo.org>
AuthorDate: 2019-06-14 13:24:41 +0000
Commit:     Jory Pratt <anarchy@gentoo.org>
CommitDate: 2019-06-14 13:24:55 +0000

    sys-boot/vboot-utils: add fts-standalone dep for musl users
    
    Closes: https://bugs.gentoo.org/687820
    Package-Manager: Portage-2.3.67, Repoman-2.3.14
    Signed-off-by: Jory Pratt <anarchy@gentoo.org>

 sys-boot/vboot-utils/vboot-utils-72_p20181229-r1.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 7 Jory A. Pratt gentoo-dev 2019-06-14 13:26:43 UTC
(In reply to Alpha Bravo from comment #5)
> The commit message claims a "musl dep fix" but the commit only deals with
> the libressl issue from bug #678594
> 
> In any case the issue with fts is not resolved, nothing changed.

I am sorry, guess I drop'd the change when I was doing the bump for libressl, thanks for reopening so I could re-address the issue.
Comment 8 Alpha Bravo 2019-07-04 17:26:06 UTC
Reopening this, as adding the dependency on fts-standalone is only one half of a solution. Additionally the linker must be told to link futility against libfts. Otherwise the build fails, cf. the Attachment build.log which was produced on a system where fts-standalone coincidentially was installed as a dependency of an unrelated package. (See Bug 688396 for a possible solution.)
Comment 9 Larry the Git Cow gentoo-dev 2020-01-13 01:07:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5e25b4aa1598f53a0712d6229df67f5564687285

commit 5e25b4aa1598f53a0712d6229df67f5564687285
Author:     Alpha Bravo <aos@ungwana.de>
AuthorDate: 2020-01-13 00:40:39 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-01-13 01:07:44 +0000

    sys-boot/vboot-utils: Bump to version 80_p20200108
    
    Closes: https://bugs.gentoo.org/688396
    Closes: https://bugs.gentoo.org/687820
    Closes: https://bugs.gentoo.org/678594
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-boot/vboot-utils/Manifest                      |   1 +
 .../files/vboot-utils-80-musl-fts.patch            |  17 ++++
 sys-boot/vboot-utils/metadata.xml                  |   5 +-
 .../vboot-utils/vboot-utils-80_p20200108.ebuild    | 104 +++++++++++++++++++++
 4 files changed, 126 insertions(+), 1 deletion(-)