Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 687508

Summary: =app-portage/portage-utils-0.80_pre20190605 - qlop -r fails to detect failed build (--keep-going?)
Product: Portage Development Reporter: Jeroen Roovers (RETIRED) <jer>
Component: ToolsAssignee: Fabian Groffen <grobian>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Jeroen Roovers (RETIRED) gentoo-dev 2019-06-06 11:16:36 UTC
1559817053:  >>> emerge (3 of 4) net-firewall/ipt_netflow-2.3 to /
1559817053:  === (3 of 4) Cleaning (net-firewall/ipt_netflow-2.3::/aches/gentoo/portage/net-firewall/ipt_netflow/ipt_netflow-2.3.ebuild)
1559817054:  === (3 of 4) Compiling/Packaging (net-firewall/ipt_netflow-2.3::/aches/gentoo/portage/net-firewall/ipt_netflow/ipt_netflow-2.3.ebuild)
1559817124:  >>> emerge (1 of 1) app-portage/portage-utils-0.80_pre20190530 to /
1559817125:  === (1 of 1) Cleaning (app-portage/portage-utils-0.80_pre20190530::/aches/gentoo/portage/app-portage/portage-utils/portage-utils-0.80_pre20190530.ebuild)
1559817126:  === (1 of 1) Compiling/Packaging (app-portage/portage-utils-0.80_pre20190530::/aches/gentoo/portage/app-portage/portage-utils/portage-utils-0.80_pre20190530.ebuild)
1559817201:  === (1 of 1) Merging (app-portage/portage-utils-0.80_pre20190530::/aches/gentoo/portage/app-portage/portage-utils/portage-utils-0.80_pre20190530.ebuild)
1559817206:  >>> AUTOCLEAN: app-portage/portage-utils:0
1559817206:  === Unmerging... (app-portage/portage-utils-0.74-r1)
1559817216:  >>> unmerge success: app-portage/portage-utils-0.74-r1
1559817223:  === (1 of 1) Post-Build Cleaning (app-portage/portage-utils-0.80_pre20190530::/aches/gentoo/portage/app-portage/portage-utils/portage-utils-0.80_pre20190530.ebuild)
1559817223:  ::: completed emerge (1 of 1) app-portage/portage-utils-0.80_pre20190530 to /
1559817224:  *** Finished. Cleaning up...
1559817224:  *** exiting unsuccessfully with status '1'.
1559817224:  *** terminating.


# qlop -r
2019-06-06T12:30:53 >>> net-firewall/ipt_netflow... (3 of 4) ETA: unknown
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-06-06 11:28:44 UTC
Not sure if this is enough information. Let me know if you need more emerge.log context.
Comment 2 Fabian Groffen gentoo-dev 2019-06-06 13:27:00 UTC
Hmmm, interesting

Is your log like the snippet (truncated at the top)?  I can fix this case where qlop will list the package as running forever, but due to Portage's crappy logging I cannot stop it from showing up during Portage's run.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2019-06-06 13:45:24 UTC
(In reply to Fabian Groffen from comment #2)
> Is your log like the snippet (truncated at the top)?

Yes, exactly like that, while no emerge process is running.

> I can fix this case
> where qlop will list the package as running forever, but due to Portage's
> crappy logging I cannot stop it from showing up during Portage's run.

1559817053:  >>> emerge (3 of 4) net-firewall/ipt_netflow-2.3 to /
1559817053:  === (3 of 4) Cleaning (net-firewall/ipt_netflow-2.3::/aches/gentoo/portage/net-firewall/ipt_netflow/ipt_netflow-2.3.ebuild)
1559817054:  === (3 of 4) Compiling/Packaging (net-firewall/ipt_netflow-2.3::/aches/gentoo/portage/net-firewall/ipt_netflow/ipt_netflow-2.3.ebuild)
1559817124:  >>> emerge (1 of 1) app-portage/portage-utils-0.80_pre20190530 to /

net-firewall/ipt_netflow fails because of a known issue (bug #678788) and likely because of a deficiency in --keep-going, the net-firewall/ipt_netflow build is never logged as failed, which would probably solve the problem in the future but obviously not now.
Comment 4 Larry the Git Cow gentoo-dev 2019-06-06 13:46:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=ca7402e12d1e149a7f2a3dee985c4e17dde6e28e

commit ca7402e12d1e149a7f2a3dee985c4e17dde6e28e
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2019-06-06 13:44:23 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2019-06-06 13:44:23 +0000

    qlop: prune running packages list more often
    
    When we don't have proof that Portage started, but we see it finishing,
    prune the entire list of unfinished packages, in order to deal with
    truncated/rotated logs.
    
    Bug: https://bugs.gentoo.org/687508
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 qlop.c | 40 +++++++++++++++++++++++-----------------
 1 file changed, 23 insertions(+), 17 deletions(-)
Comment 5 Fabian Groffen gentoo-dev 2019-06-11 07:53:42 UTC
[master 19f1ab79dd1] app-portage/portage-utils: version bump for 0.80 RC