Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 687412

Summary: app-crypt/libb2 ignores CFLAGS
Product: Gentoo Linux Reporter: Jeroen Roovers (RETIRED) <jer>
Component: Current packagesAssignee: Fabian Groffen <grobian>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 59506    

Description Jeroen Roovers (RETIRED) gentoo-dev 2019-06-05 07:58:06 UTC
>>> Compiling source in /var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449 ...
make -j3 'noCFLAGS=-mschedule=8000 -march=2.0 -ggdb -Wall -O2 -pipe -Wno-comment'
Making all in src
make[1]: Entering directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449/src'
make  all-am
make[2]: Entering directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449/src'
/bin/sh ../libtool  --tag=CC   --mode=compile hppa2.0-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I.  -DSUFFIX=  ../src/  -fopenmp  -O3 -fopenmp -c -o libb2_la-blake2s-ref.lo `test -f 'blake2s-ref.c' || echo './'`blake2s-ref.c
/bin/sh ../libtool  --tag=CC   --mode=compile hppa2.0-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I.  -DSUFFIX=  ../src/  -fopenmp  -O3 -fopenmp -c -o libb2_la-blake2b-ref.lo `test -f 'blake2b-ref.c' || echo './'`blake2b-ref.c
/bin/sh ../libtool  --tag=CC   --mode=compile hppa2.0-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I.  -DSUFFIX=  ../src/  -fopenmp  -O3 -fopenmp -c -o libb2_la-blake2sp.lo `test -f 'blake2sp.c' || echo './'`blake2sp.c
libtool: compile:  hppa2.0-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -DSUFFIX= ../src/ -fopenmp -O3 -fopenmp -c blake2b-ref.c  -fPIC -DPIC -o .libs/libb2_la-blake2b-ref.o
libtool: compile:  hppa2.0-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -DSUFFIX= ../src/ -fopenmp -O3 -fopenmp -c blake2s-ref.c  -fPIC -DPIC -o .libs/libb2_la-blake2s-ref.o
libtool: compile:  hppa2.0-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -DSUFFIX= ../src/ -fopenmp -O3 -fopenmp -c blake2sp.c  -fPIC -DPIC -o .libs/libb2_la-blake2sp.o
hppa2.0-unknown-linux-gnu-gcc: warning: ../src/: linker input file unused because linking not done
/bin/sh ../libtool  --tag=CC   --mode=compile hppa2.0-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I.  -DSUFFIX=  ../src/  -fopenmp  -O3 -fopenmp -c -o libb2_la-blake2bp.lo `test -f 'blake2bp.c' || echo './'`blake2bp.c
libtool: compile:  hppa2.0-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -DSUFFIX= ../src/ -fopenmp -O3 -fopenmp -c blake2bp.c  -fPIC -DPIC -o .libs/libb2_la-blake2bp.o
hppa2.0-unknown-linux-gnu-gcc: warning: ../src/: linker input file unused because linking not done
hppa2.0-unknown-linux-gnu-gcc: warning: ../src/: linker input file unused because linking not done
hppa2.0-unknown-linux-gnu-gcc: warning: ../src/: linker input file unused because linking not done
/bin/sh ../libtool  --tag=CC   --mode=link hppa2.0-unknown-linux-gnu-gcc  -O3 -fopenmp  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,--no-keep-memory -version-info 1:4:0 -o libb2.la -rpath /usr/lib libb2_la-blake2s-ref.lo libb2_la-blake2b-ref.lo libb2_la-blake2sp.lo libb2_la-blake2bp.lo
libtool: link: hppa2.0-unknown-linux-gnu-gcc -shared  -fPIC -DPIC  .libs/libb2_la-blake2s-ref.o .libs/libb2_la-blake2b-ref.o .libs/libb2_la-blake2sp.o .libs/libb2_la-blake2bp.o   -Wl,--as-needed  -O3 -fopenmp -Wl,-O1 -Wl,--hash-style=gnu -Wl,--no-keep-memory   -fopenmp -Wl,-soname -Wl,libb2.so.1 -o .libs/libb2.so.1.0.4
libtool: link: (cd ".libs" && rm -f "libb2.so.1" && ln -s "libb2.so.1.0.4" "libb2.so.1")
libtool: link: (cd ".libs" && rm -f "libb2.so" && ln -s "libb2.so.1.0.4" "libb2.so")
libtool: link: ( cd ".libs" && rm -f "libb2.la" && ln -s "../libb2.la" "libb2.la" )
make[2]: Leaving directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449/src'
make[1]: Leaving directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449/src'
make[1]: Entering directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449'
make[1]: Nothing to be done for 'all-am'.
make[1]: Leaving directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449'
>>> Source compiled.

I do not have -O3 in my CFLAGS.
Comment 1 Fabian Groffen gentoo-dev 2019-06-05 08:24:53 UTC
Please unset USE=native-cflags

Perhaps I set a wrong USE-default here, but it reflects basically upstream's preference.
Comment 2 Larry the Git Cow gentoo-dev 2019-06-05 08:37:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=490a4574d863b214b4585fba49ca59e8e8fbcf9c

commit 490a4574d863b214b4585fba49ca59e8e8fbcf9c
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2019-06-05 08:30:55 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2019-06-05 08:36:51 +0000

    app-crypt/libb2: unset USE=native-clags by default
    
    Closes: https://bugs.gentoo.org/687412
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>
    Package-Manager: Portage-2.3.66, Repoman-2.3.11

 app-crypt/libb2/libb2-0.98.1.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2019-06-05 09:18:24 UTC
This still ignores CFLAGS in the test phase:


libtool: link: hppa2.0-unknown-linux-gnu-gcc -shared  -fPIC -DPIC  .libs/libb2_la-blake2s-ref.o .libs/libb2_la-blake2b-ref.o .libs/libb2_la-blake2sp.o .libs/li
bb2_la-blake2bp.o   -Wl,--as-needed  -mschedule=8000 -march=2.0 -ggdb -O2 -Wl,-O1 -Wl,--hash-style=gnu -Wl,--no-keep-memory   -Wl,-soname -Wl,libb2.so.1 -o .li
bs/libb2.so.1.0.4
libtool: link: (cd ".libs" && rm -f "libb2.so.1" && ln -s "libb2.so.1.0.4" "libb2.so.1")
libtool: link: (cd ".libs" && rm -f "libb2.so" && ln -s "libb2.so.1.0.4" "libb2.so")
libtool: link: ( cd ".libs" && rm -f "libb2.la" && ln -s "../libb2.la" "libb2.la" )
make[2]: Leaving directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449/src'
make[1]: Leaving directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449/src'
make[1]: Entering directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449'
make[1]: Nothing to be done for 'all-am'.
make[1]: Leaving directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449'
>>> Source compiled.
>>> Test phase: app-crypt/libb2-0.98.1
make -j3   check
Making check in src
make[1]: Entering directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449/src'
make  blake2s-test blake2b-test blake2sp-test blake2bp-test
make[2]: Entering directory '/var/tmp/portage/app-crypt/libb2-0.98.1/work/libb2-73d41c8255a991ed2adea41c108b388d9d14b449/src'
hppa2.0-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I.    -fopenmp  -O3 -fopenmp -c -o blake2s-test.o blake2s-test.c
[...]
Comment 4 Larry the Git Cow gentoo-dev 2019-06-05 09:31:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c872ec9942b167d7d42c7d748c88a0827c52f022

commit c872ec9942b167d7d42c7d748c88a0827c52f022
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2019-06-05 09:30:47 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2019-06-05 09:30:57 +0000

    app-crypt/libb2: fix check to respect CFLAGS, thanks jer
    
    Closes: https://bugs.gentoo.org/687412
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>
    Package-Manager: Portage-2.3.66, Repoman-2.3.11

 app-crypt/libb2/libb2-0.98.1.ebuild | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
Comment 5 Fabian Groffen gentoo-dev 2019-06-05 09:31:29 UTC
apologies, hopefully I got it right this time, thanks!
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2019-06-05 10:26:04 UTC
That works for me now. Thanks.