Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 686652

Summary: >=sys-fs/lvm2-2.02.184: fails to build with sh -> mksh: command-lines-input.h:1009:1: error: missing terminating " character
Product: Gentoo Linux Reporter: William <sirrobin2318>
Component: Current packagesAssignee: Robin Johnson <robbat2>
Status: RESOLVED FIXED    
Severity: normal CC: agk, alexander, cardoe, jstein
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: lvm2-2.02.184-r3_MKSH.build.log
patch
lvm2-2.02.184-r4/temp/build.log

Description William 2019-05-24 08:58:04 UTC
Created attachment 577702 [details]
lvm2-2.02.184-r3_MKSH.build.log

Hi!

with eselect sh set bash, it builds fine, with mksh it fails with the attached build log.
Comment 1 Alexander Tsoy 2019-05-24 16:05:19 UTC
Created attachment 577710 [details]
patch

Please try attached patch
Comment 2 William 2019-05-27 20:38:25 UTC
Yes, that works!
Comment 3 William 2019-06-11 07:17:28 UTC
Created attachment 579516 [details]
lvm2-2.02.184-r4/temp/build.log
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-06-18 08:31:10 UTC
*** Bug 688088 has been marked as a duplicate of this bug. ***
Comment 5 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-06-18 08:31:15 UTC
*** Bug 688276 has been marked as a duplicate of this bug. ***
Comment 6 Larry the Git Cow gentoo-dev 2019-06-18 09:03:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=708fc54cc41e78710557966a421eb734d07b3e64

commit 708fc54cc41e78710557966a421eb734d07b3e64
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-06-18 09:02:34 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-06-18 09:03:20 +0000

    sys-fs/lvm2: Fixed build with app-shells/mksh
    
    Thanks-to: Alexander Tsoy <alexander@tsoy.me>
    Closes: https://bugs.gentoo.org/686652
    Package-Manager: Portage-2.3.67, Repoman-2.3.14
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 sys-fs/lvm2/files/lvm2-2.02.184-mksh_build.patch | 13 +++++++++++++
 sys-fs/lvm2/lvm2-2.02.185.ebuild                 |  2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)