Summary: | savedconfig.eclass: save_config() should re-use configuration file scheme used by restore_config() | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis <arfrever.fta> |
Component: | Eclasses | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jer, ulm |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=546690 https://bugs.gentoo.org/show_bug.cgi?id=686296 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 686350, 686296 | ||
Attachments: | Patch |
Description
Arfrever Frehtes Taifersar Arahesis
2019-05-19 23:39:49 UTC
Created attachment 577332 [details, diff]
Patch
Thanks, posted for review https://archives.gentoo.org/gentoo-dev/message/4071540c948529c73df1cb327a34cae2 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0c35ad8ee8f8f89ba6044dd5b44e9479c6a1775 commit a0c35ad8ee8f8f89ba6044dd5b44e9479c6a1775 Author: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> AuthorDate: 2019-08-03 11:41:09 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2019-08-08 19:47:41 +0000 savedconfig.eclass: Re-use configuration file scheme Make save_config() re-use configuration file scheme used by restore_config(). Fixes: https://bugs.gentoo.org/686348 Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> eclass/savedconfig.eclass | 40 +++++++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 13 deletions(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eb71dfec11e09ae40ae90f27305948097b6591a2 commit eb71dfec11e09ae40ae90f27305948097b6591a2 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2021-10-31 19:16:06 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2021-11-05 19:17:13 +0000 savedconfig.eclass: do not re-use config file scheme This causes file collisions when save_config is used in a multi-slotted package and the config file is named ${PN}. Reverts: a0c35ad8ee8f8f89ba6044dd5b44e9479c6a1775 Bug: https://bugs.gentoo.org/686348 Closes: https://bugs.gentoo.org/818904 Signed-off-by: Mike Gilbert <floppym@gentoo.org> eclass/savedconfig.eclass | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) Could it be that the last commit https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eb71dfec11e09ae40ae90f27305948097b6591a2 caused a bug where the savedconfig of the previously emerge package version is not correctly applied on updates, e.g. when updating from gentoo-kernel-5.15.2 to gentoo-kernel-5.15.3 the savedconfig from 5.15.2 is not applied to 5.15.3? This might also be related to https://bugs.gentoo.org/824594. |