Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 685776

Summary: net-misc/unison-2.51 USE=-ocamlopt strips bytecode from binaries
Product: Gentoo Linux Reporter: spock128
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: UNCONFIRMED ---    
Severity: normal CC: bruce, gentoo, sam
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: patch to disable stripping when not building native code
patch to disable stripping when not building native code
disable strip if !ocamlopt
patch to disable stripping when not building native code

Description spock128 2019-05-13 03:49:47 UTC
Created attachment 576256 [details, diff]
patch to disable stripping when not building native code

net-misc/unison with the -ocamlopt use flag seems to enable the -custom ocamlc flag in its build system.

According to the ocamlc man page, executables generated with -custom should not be stripped. Otherwise the bytecode will be removed and attempting to run unison will result in "No bytecode file specified." being displayed.

As a potential solution, I added this line to unison-2.51.2.ebuild

RESTRICT="!ocamlopt? ( strip )"

And also patched the unison Makefile to disable stripping (attachment).

The resulting (albeit unstripped) binary seems to work properly.
Comment 1 spock128 2019-05-13 04:02:12 UTC
Created attachment 576258 [details, diff]
patch to disable stripping when not building native code

ack flubbed the original patch
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-22 12:21:28 UTC
Is this still an issue?
Comment 3 spock128 2020-10-25 04:37:35 UTC
Recent unison ebuilds seem to address this issue.
Comment 5 spock128 2023-03-18 06:24:09 UTC
Created attachment 858151 [details, diff]
disable strip if !ocamlopt
Comment 6 spock128 2023-03-18 06:25:19 UTC
Created attachment 858153 [details, diff]
patch to disable stripping when not building native code

updated to work at -p1
Comment 7 spock128 2023-03-18 06:27:10 UTC
There appears to be a regression for unision-2.51.5, with the same fix. See patches for ebuild and source