Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 685774

Summary: dev-libs/libinput: Misplaced dependencies on dev-python/{commonmark,recommonmark,sphinx,sphinx_rtd_theme}, app-doc/doxygen and media-gfx/graphviz
Product: Gentoo Linux Reporter: Arfrever Frehtes Taifersar Arahesis <arfrever.fta>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: polynomial-c, x11
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Patch

Description Arfrever Frehtes Taifersar Arahesis 2019-05-13 03:00:33 UTC
dev-python/{commonmark,recommonmark,sphinx,sphinx_rtd_theme}, app-doc/doxygen and media-gfx/graphviz are used as tools, and should be specified in BDEPEND. In case of the Python modules, Python interpreter is called and needs them in CBUILD.


Ebuild also has commented out dependencies for USE="test", currently specified for DEPEND:
#       test? (
#               >=dev-libs/check-0.9.10
#               dev-util/valgrind
#               sys-libs/libunwind )

Actual examination of these dependencies reveals that:
1. dev-util/valgrind would be in BDEPEND
   (dev-util/valgrind contains some headers, but they are not included in dev-libs/libinput.)
2. dev-libs/check would be in DEPEND
   (dev-libs/check contains /usr/bin/checkmk executable, but it is not used in dev-libs/libinput.)
3. sys-libs/libunwind usage was dropped by upstream in:
   https://gitlab.freedesktop.org/libinput/libinput/commit/c8e0e94c006a714212d56bde8eaa88ec5f08cfc3
   This commit replaced optional usage of libunwind and addr2line with optional usage of gstack (which is not packaged in Gentoo).
Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-05-13 03:13:35 UTC
Created attachment 576254 [details, diff]
Patch
Comment 2 Larry the Git Cow gentoo-dev 2019-05-13 08:06:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b22eb49bab1deed68b73b664b2b0b91d78ea9d9

commit 2b22eb49bab1deed68b73b664b2b0b91d78ea9d9
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2019-05-13 03:11:06 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-05-13 08:06:41 +0000

    dev-libs/libinput: Move tools needed for USE="doc" to BDEPEND.
    
    Fix commented out dependencies for USE="test".
    
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Closes: https://bugs.gentoo.org/685774
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 dev-libs/libinput/libinput-1.12.6.ebuild | 27 ++++++++++++---------------
 dev-libs/libinput/libinput-1.13.1.ebuild | 27 ++++++++++++---------------
 dev-libs/libinput/libinput-1.13.2.ebuild | 27 ++++++++++++---------------
 3 files changed, 36 insertions(+), 45 deletions(-)