Bug 685514 – dev-util/glslang: does not build/install shared libraries

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description William Breathitt Gray 2019-05-10 11:01:15 UTC]

Default configuration for cmake builds of packages on Gentoo is to set BUILD_SHARED_LIBS=ON in order to build shared libraries. Despite this, the glslang ebuild is only building/installing static libraries.

If I manually build glslang from its source code tarball by executing "cmake -DBUILD_SHARED_LIBS ..." then the shared libraries are built as expected.

There appears to be something in the default configuration for the glslang ebuild that is causing the libraries to build as static instead of shared.

Reproducible: Always

Steps to Reproduce:
1. emerge glslang
2.
3.

[Comment 1 Jonas Stein 2019-05-10 18:22:57 UTC]

Thank you for the report. Please recompile and 
*attach* the logfiles and 
paste the emerge info as described on
https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
The logs must be part of the ticket, but not on external websites.
We need to have all information at hand before ticket assignment, so that the maintainer can look after it in one session with minimal number of callbacks.
Please reopen this ticket (Status:unconfirmed) afterwards.

[Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-05-10 20:19:20 UTC]

I can reproduce that dev-util/glslang-7.11.3114_pre20190415 installs only static libraries.

# qlist dev-util/glslang | sort | grep -E "\.a"
/usr/lib32/libHLSL.a
/usr/lib32/libOGLCompiler.a
/usr/lib32/libOSDependent.a
/usr/lib32/libSPIRV.a
/usr/lib32/libSPVRemapper.a
/usr/lib32/libglslang.a
/usr/lib64/libHLSL.a
/usr/lib64/libOGLCompiler.a
/usr/lib64/libOSDependent.a
/usr/lib64/libSPIRV.a
/usr/lib64/libSPVRemapper.a
/usr/lib64/libglslang.a
# qlist dev-util/glslang | sort | grep -E "\.so"
#

[Comment 3 Arfrever Frehtes Taifersar Arahesis 2019-05-10 20:22:30 UTC]

In CMakeLists.txt:

option(BUILD_SHARED_LIBS "Build Shared Libraries" OFF)

set(LIB_TYPE STATIC)

if(BUILD_SHARED_LIBS)
    set(LIB_TYPE SHARED)
endif()

[Comment 4 Arfrever Frehtes Taifersar Arahesis 2019-05-10 20:24:56 UTC]

(In reply to William Breathitt Gray from comment #0)
> Default configuration for cmake builds of packages on Gentoo is to set
> BUILD_SHARED_LIBS=ON in order to build shared libraries

This is not fully true.
BUILD_SHARED_LIBS=ON is set only for EAPI >= 7.
In cmake-utils.eclass:

    if [[ ${EAPI} != [56] ]]; then
        cat >> "${common_config}" <<- _EOF_ || die
            SET (CMAKE_INSTALL_DOCDIR "${EPREFIX}/usr/share/doc/${PF}" CACHE PATH "")
            SET (BUILD_SHARED_LIBS ON CACHE BOOLEAN "")
        _EOF_
    fi


All ebuilds of dev-util/glslang currently use EAPI="6".

[Comment 5 Larry the Git Cow 2019-05-10 22:12:37 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7df6a1613bcdeaf71de23241aa81c45b3d24c39b

commit 7df6a1613bcdeaf71de23241aa81c45b3d24c39b
Author:     Nick Sarnie <[e-mail]>
AuthorDate: 2019-05-10 22:05:55 +0000
Commit:     Nick Sarnie <[e-mail]>
CommitDate: 2019-05-10 22:12:16 +0000

    dev-util/glslang: Bump to EAPI 7
    
    Closes: https://bugs.gentoo.org/685514
    Package-Manager: Portage-2.3.66, Repoman-2.3.12
    Signed-off-by: Nick Sarnie <[e-mail]>

 .../glslang/glslang-7.11.3114_pre20190415-r1.ebuild     | 17 +++++++++++++++++
 dev-util/glslang/glslang-9999.ebuild                    |  4 ++--
 2 files changed, 19 insertions(+), 2 deletions(-)