Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 685484

Summary: net-fs/samba: add profiling-data USE flag
Product: Gentoo Linux Reporter: Marc Joliet <marcec>
Component: Current packagesAssignee: Gentoo's SAMBA Team <samba>
Status: RESOLVED FIXED    
Severity: normal Keywords: PullRequest
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/11850
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Output of "git log -p -C -C origin/master.. -- net-fs/samba/"

Description Marc Joliet 2019-05-09 20:12:07 UTC
I'd like to see support for the Samba profiling-data configure flag added, as it's a requirement for Samba support in netdata.

I opened a (more or less RFC) PR on GitHub a while ago, but I wonder if the Samba team is not on Github (because the automatic bug assignment didn't work).  Does the Samba team prefer different channels for contributions, e.g., Patches via Email?
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-05-09 20:18:39 UTC
Please add the URI to the Pull Request to "See Also" in this bug...
Comment 2 Marc Joliet 2019-05-09 20:29:07 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #1)
> Please add the URI to the Pull Request to "See Also" in this bug...

Ha, I wasn't expecting a response this quickly.  I had updated the PR to include a Closes tag for this bug and was going to wait for the bot to automatically add a link, but I can go ahead and pre-empt it.
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-05-09 20:36:28 UTC
If you want to help me a bit more, please do the following:

- Only add the changes to latest samba-4.x.y releases with a revbump.
- Please attach a unified diff (diff -u) file to this bug so I can see easily what changes you did to the ebuild(s).
Comment 4 Marc Joliet 2019-05-09 20:55:28 UTC
Thanks for the quick responses.  I'll do as you suggest, but not until the weekend (probably Sunday).
Comment 5 Marc Joliet 2019-05-11 18:29:03 UTC
Created attachment 576062 [details, diff]
Output of "git log -p -C -C origin/master.. -- net-fs/samba/"

OK, here's the output of "git log -p -C -C origin/master.. -- net-fs/samba/".  Note that I have posting rights to gentoo-dev (due to my status as proxy-maintainer), just in case proper Email based PRs are fine with you.
Comment 6 Larry the Git Cow gentoo-dev 2019-05-23 07:43:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a445adef0735f756edaaa7115400d5068fdbec3

commit 8a445adef0735f756edaaa7115400d5068fdbec3
Author:     Marc Joliet <marcec@gmx.de>
AuthorDate: 2019-04-28 12:40:24 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-05-23 07:43:37 +0000

    net-fs/samba: add new USE flag "profiling-data"
    
    Add a new USE flag "profiling-data" that, when set, allows the use of
    the "smbd profiling level" option in smbd.conf or, equivalently, the -P
    option to smbd.  This is useful in conjunction with monitoring software,
    e.g., netdata.
    
    Closes: https://bugs.gentoo.org/685484
    Package-Manager: Portage-2.3.62, Repoman-2.3.11
    Signed-off-by: Marc Joliet <marcec@gmx.de>
    Closes: https://github.com/gentoo/gentoo/pull/11850
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 net-fs/samba/metadata.xml           |   1 +
 net-fs/samba/samba-4.10.2-r1.ebuild | 309 ++++++++++++++++++++++++++++++++++++
 net-fs/samba/samba-4.8.9-r1.ebuild  | 303 +++++++++++++++++++++++++++++++++++
 net-fs/samba/samba-4.9.6-r1.ebuild  | 307 +++++++++++++++++++++++++++++++++++
 4 files changed, 920 insertions(+)
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-05-23 07:45:36 UTC
Thank you for the PR and sorry for the commit delay.

I took the liberty to not add your changes to samba-4.5.x and samba-4.7.x because these versions are already deprecated by upstream and should be removed from Gentoo.
Comment 8 Marc Joliet 2019-05-28 19:21:13 UTC
Now I'm the one being late, but I wanted to say thanks anyway :) !
Comment 9 Marc Joliet 2019-05-28 19:35:53 UTC
(In reply to Marc Joliet from comment #8)
> Now I'm the one being late, but I wanted to say thanks anyway :) !

Dammit, and because I just realized how badly that could sound, let me clarify what I meant:
1.) Thank you!
2.) I'm sorry for posting so long after the bug was closed.