| Summary: | net-print/cnijfilter-3.40-r2::bar - eclass/ecnij.eclass broken | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Evert <evert.gentoo> |
| Component: | Overlays | Assignee: | tokiclover <tokiclover> |
| Status: | UNCONFIRMED --- | ||
| Severity: | normal | CC: | jstein |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
eclass/ecnij.eclass.patch
modified ecnij.eclass for review modified ecnij.eclass for review modified eclass/ecnij.eclass - fix missing files & QA Notices |
||
Created attachment 575132 [details]
modified ecnij.eclass for review
I digged a bit further into ecnij.eclass and found some things which you may not have intended. Especially myeconfargs which keeps on growing and growing with any dir match. Other than that, I'm still puzzled by the purpose of ${license%${lingua:0:1}.txt}.txt which I reckon didn't work anyway.
So I changed things here and there, see this attachment. If you have the time, you may want to take a look into this. If not, fine to me too. For mg5200 the final result is identical however I cannot speak about other models where it may improve or even break the final result.
Created attachment 575162 [details]
modified ecnij.eclass for review
small QA fix
Created attachment 575230 [details]
modified eclass/ecnij.eclass - fix missing files & QA Notices
Added QA comment into eclass/ecnij.eclass
Note: this modified eclass/ecnij.eclass
- restores the installation of previously missing files
- fixes QA Notices caused by incorrect myeconfargs assignments
|
Created attachment 575122 [details, diff] eclass/ecnij.eclass.patch After emerge =net-print/cnijfilter-3.40-r2::bar a lot of files are missing. I tracked down the issue to eclass/ecnij.eclass The broken part (2x) is dir_src_command "emake" "DESTDIR=\"${D}\" install" where "DESTDIR=\"${D}\" install" is seen as one argument. This must be specified 2 arguments. I fixed the issue, see patch in attachment.